Gold872 / elastic-dashboard

A simple and modern dashboard for FRC
MIT License
71 stars 13 forks source link

added dark mode & theme features #65

Closed DanPeled closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.03%. Comparing base (8bc547d) to head (fce1b18).

Files Patch % Lines
lib/main.dart 12.50% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #65 +/- ## ========================================== + Coverage 45.85% 46.03% +0.17% ========================================== Files 74 74 Lines 7541 7579 +38 ========================================== + Hits 3458 3489 +31 - Misses 4083 4090 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Gold872 commented 1 month ago

I think allowing users to change the theme variant is a nice addition, but for adding light mode, I can't find a good color selection that doesn't make the entire app hard to read, as most of the colors used for small decorations (box shadows, dragging highlights, titles, etc) was designed with dark mode in mind. I'll continue playing around with it but I don't know if it will be something I want to include with this PR

Gold872 commented 1 month ago

I was able to get the light mode to look okay-ish, but there's a big issue with having to update all the widgets on the screen whenever the brightness changes, which right now the app isn't really structured to do since not all widgets can be rebuilded on command (which is why many apps require restarting after changing themes).

For now I'll push the changes for the dark mode theming and work from there, what might have to be done is add a pop-up warning the user that the app will have to be restarted for all the theme changes to take effect

DanPeled commented 1 month ago

I was able to get the light mode to look okay-ish, but there's a big issue with having to update all the widgets on the screen whenever the brightness changes, which right now the app isn't really structured to do since not all widgets can be rebuilded on command (which is why many apps require restarting after changing themes).

For now I'll push the changes for the dark mode theming and work from there, what might have to be done is add a pop-up warning the user that the app will have to be restarted for all the theme changes to take effect

Ye that makes sense, I didn't really like how the light mode looks how I made it anyway (Not really a fan of light mode, hurts my eyes)

Gold872 commented 1 month ago

Ye that makes sense, I didn't really like how the light mode looks how I made it anyway (Not really a fan of light mode, hurts my eyes)

In that case I suggest removing the light mode feature and have only the theme variant selection feature available

DanPeled commented 1 month ago

Ye that makes sense, I didn't really like how the light mode looks how I made it anyway (Not really a fan of light mode, hurts my eyes)

In that case I suggest removing the light mode feature and have only the theme variant selection feature available

ill modify this PR then

Gold872 commented 1 month ago

This PR should fix #33