search

Gold872 / elastic-dashboard

A simple and modern dashboard for FRC
MIT License
74 stars 14 forks source link

Save old topics #78

Closed DanPeled closed 1 week ago

DanPeled commented 1 month ago

Saves the topics posted each time the add widget dialog is opened, maybe should add that also when the file is saved, up to the reviewer to decide, allows to modify the tab grid with the old widgets even when nto connected to the robot / sim

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.38%. Comparing base (bcb85f7) to head (8ab2f69). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/pages/dashboard_page.dart 41.17% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ========================================== - Coverage 63.41% 63.38% -0.04% ========================================== Files 75 75 Lines 7867 7887 +20 ========================================== + Hits 4989 4999 +10 - Misses 2878 2888 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Gold872 commented 1 month ago

I was thinking about this PR recently, and I don't think it makes much sense to save NT data into the json for the layout. What I think would be better is to use the advantagescope NT replay feature to populate layouts when disconnected from the robot, since this can have several shortcomings, such as needing to the the value of a .type topic and not having a value.

DanPeled commented 1 month ago

@Gold872 I want to achieve the restore of the topics even when it wasn't connected on the last power-on of the local machine, will what u suggested be able to achieve that? (I mean that I will be able to access the topics from any time I want)