GoldenGnu / jeveassets

jEveAssets is an out-of-game asset manager for Eve-Online, written in Java
http://eve.nikr.net/jeveasset
GNU General Public License v2.0
155 stars 39 forks source link

Why is jEveAssets reading my local data? #24

Closed lord-carlos closed 6 years ago

lord-carlos commented 6 years ago

Jeveassets just died on me: https://eve.nikr.net/jeveassets/bugs/?#bugid616 Malformed input or input contains unmappable characters: /home/carlos/Klei unter den F����en.mp4

For what does it need to know what files I have in /home?

Is there a way I can see the full stacktrace? I would love to see which heveassts method caused this.

GoldenGnu commented 6 years ago

1) Thank you for your bug report and thank you for creating a GitHub issue too. It helps a lot to be able to talk with the user, who found the bug.

2) I not sure what it was doing in that folder, maybe it was creating JFileChooser for the user directory, but, it's just a guess.

3) That is the full stack trace, it's not a jEveAssets bug, it's a java bug. It's most likely related to JDK-8003228. There is a question on Stack Overflow too: InvalidPathException for chinese filename

I will need a few things to debug this:

lord-carlos commented 6 years ago
  1. Well the last line is at javax.swing.plaf.basic.BasicDirectoryModel$LoadFilesThread.run(BasicDirectoryModel.java:228) should a full stack trace not tell me what code in jEveAssets called this method?

Anyhow, when I get home I will check for the data you asked for. Poke me again in a few days, because I might forget.

GoldenGnu commented 6 years ago

Java stack traces doesn’t always work like that, because, a lot of the GUI code is part of Java. Swing sometimes throws errors, that is not the result of a jEveAsset call, but, a result of the user interacting with the GUI.

lord-carlos commented 6 years ago

I still feel uneasy about it reading my data. Because, you know, around here we don't trust people from Sjælland.

GoldenGnu commented 6 years ago

You can test this is true, by: 1) Go to the Assets Tool 2) Click Export 3) Press Default 4) Press OK The JFileChooser should now open in your home directory

don't trust people from Sjælland.

That is fair and but, you don't have to rely on trust, It would be much better if you did a full code review of the entire code base of jEveAssets, before you use it again IMHO. Please, create issues for any bugs you find along the way, thanks :D

GoldenGnu commented 6 years ago

https://github.com/GoldenGnu/jeveassets/releases/tag/jeveassets-5.1.1 have been released, if you could verify that it works without the command line parameters, that would be great.

I'm going to close this issue, but, please, reply here when you have tested the latest version, thanks.

lord-carlos commented 6 years ago

It's gucci now! Works fine. Thanks for the quick fix.

GoldenGnu commented 6 years ago

Thank you for verifying the fix :)