search

GoldenGnu / jeveassets

jEveAssets is an out-of-game asset manager for Eve-Online, written in Java
http://eve.nikr.net/jeveasset
GNU General Public License v2.0
156 stars 39 forks source link

Stockpiles: Hangar Flag matches all flags #358

Closed LakMoore closed 1 year ago

LakMoore commented 1 year ago

As soon as I add the "Hangar" flag to my filter, the items are included in the stockpile regardless of their flag image

GoldenGnu commented 1 year ago

So, I finally got around to look at the code. It checks if any of the parent assets have the flag too. I think it would be a good improvement to add an option to only match the exact assets. So, this is now a feature request, as apparently this is how it was made to work (long time ago).

The containers filter already have this option. Via a checkbox called "Include containers". This should be renamed to something better and have a ToolTip explaining the feature.

LakMoore commented 1 year ago

Interesting. I imagine that has its use cases.

My use case is to distinguish between a module in the hanger to be sold or a module in use, fitted to a ship.

Maybe I’m filtering on the wrong thing.

I think I actually started using “container is ‘None’”

On Mon, 20 Feb 2023 at 00:11, GoldenGnu @.***> wrote:

So, I finally got around to look at the code. It checks if any of the parent assets have the flag too. I think it would be a good improvement to add an option to only match the exact assets. So, this is now a feature request, as apparently this is how it was made to work (long time ago).

— Reply to this email directly, view it on GitHub https://github.com/GoldenGnu/jeveassets/issues/358#issuecomment-1436141547, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSRIISSQ7AT2AVZNJZCDNTWYKZCHANCNFSM6AAAAAASMAFGSM . You are receiving this because you authored the thread.Message ID: @.***>

GoldenGnu commented 1 year ago

Released in 7.5.0