search

GoldenGnu / jeveassets

jEveAssets is an out-of-game asset manager for Eve-Online, written in Java
http://eve.nikr.net/jeveasset
GNU General Public License v2.0
155 stars 39 forks source link

Issue 366 #367

Closed jpkoester1 closed 1 year ago

jpkoester1 commented 1 year ago

This pull request implements feature request #366. When creating stockpiles from other jEveAssets Tabs (e.g. contracts, fittings, etc...) the newly created stockpile will now use the amounts from the original tab where the stockpile was created from.

GoldenGnu commented 1 year ago

Thank you for doing the PR (Yay 🎉)

Creating a branch for the PR is the correct way to do it, but, since it needs to be merged into feature-branch the branch needs to be created from feature-branch (not master).

Also, you need to do a few more changes, since you're now a contributor. You will need to add your name and/or an alias the following places: https://github.com/GoldenGnu/jeveassets/blob/feature-branch/src/main/java/net/nikr/eve/jeveasset/gui/dialogs/AboutDialog.java#L96 https://github.com/GoldenGnu/jeveassets/blob/feature-branch/credits.txt#L25

I'm going to close this PR, so you can make a new one. I'm available on discord, if you need help with it.