Stockpile --> Shopping list does not respect Contracts "Matching all" settings

GoldenGnu / jeveassets

jEveAssets is an out-of-game asset manager for Eve-Online, written in Java

http://eve.nikr.net/jeveasset

GNU General Public License v2.0

147 stars 36 forks source link

Stockpile --> Shopping list does not respect Contracts "Matching all" settings #403

Closed jpkoester1 closed 10 months ago

jpkoester1 commented 11 months ago

Shopping list with contracts "match all" activated leads to mismatch between the stockpile window and the resulting shopping list. Please note that Nanite Repair Paste is not included in the shopping list:

if matching all is disabled the shopping list is exactly the same and matches the stockpile window:

jpkoester1 commented 11 months ago

looks like StockpileShoppingListDialog.java Line 284 iterates through all contract items no matter what the setting regarding "Match all" is.

GoldenGnu commented 11 months ago

[ ] StockClaim and StockItem store matching contractIDs.
[ ] StockClaim.matches() check contractIDs
[ ] StockClaim.compareTo() sort matchAll first

GoldenGnu commented 10 months ago

Released in 7.7.0 Now also works with subpiles