search

GoldenGnu / jeveassets

jEveAssets is an out-of-game asset manager for Eve-Online, written in Java
http://eve.nikr.net/jeveasset
GNU General Public License v2.0
156 stars 38 forks source link

UI Request: Market Orders (history aka fulfilled orders) #463

Open aixtools opened 5 months ago

aixtools commented 5 months ago

There is a column "market price" that is used for calculating "market margin".

IMHO: it would be an improvement to the UI to record the market price when the system does an upload and sees an order as fulfilled. And a date of fulfilled (for a formula to compute number of days for order to fullfill).

My guess is that the market price - even for fulfilled orders - is the current price.

A nice twist to this - for fulfilled orders (and maybe canceled/expired orders) is to have a way to compare the price then with the price now. And, maybe for open orders - to record the price when the order was first placed/modified with the current price. This field could be re-used for the price at completion to current price.

aixtools commented 5 months ago

my apologies for "more than one thing" in the issue. I can remake if needed.

GoldenGnu commented 5 months ago

Not a problem in this case :)

It would require that you actually update price data on the date in question, otherwise jEveAssets won't have any price data.

market price issued ✔️ market price done (Fulfilled/expired/etc.) ✔️ See fulfilled question Fulfilled ❓ It's not possible to know the exact time an order was fulfilled, as the data is not in ESI, on each update the order will either be fulfilled or not fulfilled and that is the only data available, would that be sufficient?

The data is in PriceHistoryDatabase

aixtools commented 5 months ago

what I was thinking is that when jeveassets sets (or sees) the status to fulfilled it use the current date. Might need a hidden field to remember that it has already seen the order as fulfilled. If I am late by days - that's my problem. I expected that ESI didn't include the fulfilled moment. (although it could be discovered, perhaps, by looking at market transactions history :p)