GoldenGnu / jeveassets

jEveAssets is an out-of-game asset manager for Eve-Online, written in Java
http://eve.nikr.net/jeveasset
GNU General Public License v2.0
147 stars 36 forks source link

Stockpile Target Truncation issue (fixed on non-subpiles but subpiles still truncating weird) #467

Closed shiek403 closed 3 weeks ago

shiek403 commented 1 month ago

a followup to #431 ( and I have verified I am running 7.9.0) now all the normal target fields truncate and fill correctly, but the subpile multiplier still shows "… "unless you shrink the window in which case it starts filling in the numbers but then the target numbers are too small Screenshot 2024-06-01 083523 Screenshot 2024-06-01 083438 the ones with the pencil edit guy are all just … when there is definitely enough space to show the number, and the weird part is the shrinking, if you shrink the column, it actually starts to show the number :)

GoldenGnu commented 1 month ago

Do you have auto resize of columns enabled?

shiek403 commented 1 month ago

I did, and I played with all the options that's how I found that by clicking "disable" and then resizing it manually, if you squish the numbers, the "…"'s slowly become the actual numbers, but only when squished very small

GoldenGnu commented 1 month ago

I'm not able to reproduce it. What are your OS, java version and java vendor?

shiek403 commented 1 month ago

oh interesting! I love a good un-reproducible! Win 10, 1.8.0_411-b09 and oracle's java if it's just a me problem I'll stop complaining :) so it only shows up on the areas with the edit icon for me, all the others scale correctly, but ones with the edit icon act in such a way adding more screenshots to show what I'm seeing OH! and in playing with it, I managed to make the edit pencil to sneak away as well! Screenshot 2024-06-01 104317 Screenshot 2024-06-01 104153 Screenshot 2024-06-01 104132 Screenshot 2024-06-01 103929

GoldenGnu commented 1 month ago

I don’t think it’s just you, I didn’t mean to insinuate that. However, I will need to figure out what trigger the bug to fix it.

shiek403 commented 4 weeks ago

I only see it on fields with the pencil. if that helps if there is anything I can do to help or any files I can upload or show just let me know :)

GoldenGnu commented 4 weeks ago

I think I have found the bug, however, since I'm not able to reproduce it myself, I would like you to try a dev build with the fix:

Super important dev build info: https://wiki.jeveassets.org/devbuild (please, read it - it's very shot)

Download: https://eve.nikr.net/jeveassets/jeveassets-7.9.1-dev1-stockpile-target.zip

The dev build is missing ESI authorization information, so you will not be able to update from ESI, this shouldn't be an issue for testing, so, I'm not going to correct it.

shiek403 commented 4 weeks ago

Unfortunately I still have the truncating and can make the pencil float away even on the new dev build.

shiek403 commented 4 weeks ago

Wait I might be on to something went back to prod 7.9, and went to colors and look and feel in the options, and turned off flat dark, and went back to defaul(windows), and its gone! I can't make it happen. but when I switch to the "flat dark" or "flat dracula" (which is what I had it in usually) it comes back! hope that helps!

shiek403 commented 4 weeks ago

in fact, having gone through them, I can recreate this bug on ALL the flat options, and NONE of the options that DON'T say flat :)

GoldenGnu commented 4 weeks ago

I'm still not able to reproduce it, could you take a screenshot of the entire jEveAssets window with the stockpile tab open showing an entire stockpile with the target ..., in the dev build

shiek403 commented 4 weeks ago

Sure thing! also adding the shots where I "fix" it by changing the style, and what my current looks are in case that helps. Screenshot 2024-06-02 103532 Screenshot 2024-06-02 102825 Screenshot 2024-06-02 102732 Screenshot 2024-06-02 103212

GoldenGnu commented 4 weeks ago

Thank you! I think it may be a caching issue for the width of the target column. It’s going to require a bit of a refactoring to work around. I hope I can get time to do it tomorrow, but, we’ll see. I’’ll post here when it’s done and I have something new for you to test. Thanks you very much for working with me to figure this out.

GoldenGnu commented 4 weeks ago

This should fix the bug (hopefully for real this time).

Super important dev build info: https://wiki.jeveassets.org/devbuild (please, read it - it's very shot)

Download: https://eve.nikr.net/jeveassets/jeveassets-7.9.1-dev2-stockpile-target.zip

shiek403 commented 4 weeks ago

lol I must REALLY have something brokenon my end... cause yeah its still there... Squished to Show numbers Screenshot 2024-06-03 082801 auto size Screenshot 2024-06-03 082728 extra wide Screenshot 2024-06-03 082707

shiek403 commented 4 weeks ago

But still, if I DON'T use a flat option in the skins, everything works great. its ONLY on the ones that say "flat" that this happens unfortunately, the only dark options area also flat.

GoldenGnu commented 4 weeks ago

Two build to try this time. I'm quickly running out of ideas, so hopefully one or the other will work. Thank you for helping me fix this complex issue

Super important dev build info: https://wiki.jeveassets.org/devbuild (please, read it - it's very shot)

Download: https://eve.nikr.net/jeveassets/jeveassets-7.9.1-dev3-stockpile-target.zip https://eve.nikr.net/jeveassets/jeveassets-7.9.1-dev4-stockpile-target.zip

shiek403 commented 4 weeks ago

I am actually having quite a bit of fun testing them :) but unfortunately... neither of them fixed it. I'm REALLY hoping there isn't something specific about my build/puter/something that is causing it and we are chasing an issue exclusive to me... Screenshot 2024-06-03 104750 Screenshot 2024-06-03 104554

GoldenGnu commented 4 weeks ago

I’m afraid, I will probably have to be able to reproduce it to actually fix. If you’re willing to share your settings I think that will have to be the next step.

In the data directory in the settings location find the settings.xml, zip it, and email it to me at niklaskr@gmail.com

Hopefully I will be able to reproduce and figure out what is happening, because, I’m pretty lost ATM

shiek403 commented 4 weeks ago

Sent :)

GoldenGnu commented 3 weeks ago

I'm not able to reproduce it.

I would suggest uninstalling all versions of java and downloading the latest version from java.com

shiek403 commented 3 weeks ago

FUN! thanks for trying! gives me hope that on my next PC it will be fixed, and for now its not like it's a gamebreaking bug or anything! I did as you recommended and unfortunately even with fresh java installs, it seems to still persist! but I'll just live with my "…"'s till I get a new build! thanks again! love the app!

GoldenGnu commented 3 weeks ago

Thank you for the kind words - I'm sorry I wasn't able to fix it. Ofc. if I'm ever able to reproduce I will do what I can to fix it. I will include the fixes in the next release, as I do think there was at least some bugs in the current code.