search

GoldenGnu / jeveassets

jEveAssets is an out-of-game asset manager for Eve-Online, written in Java
http://eve.nikr.net/jeveasset
GNU General Public License v2.0
156 stars 38 forks source link

When including corporation contracts in the asset view the owner should be the corp instead of the character #476

Closed jpkoester1 closed 1 month ago

jpkoester1 commented 4 months ago

I have set the "Include sell contracts" flag for the Assets tool: image

In the Assets tool I can see a contract that has one of my characters set as its owner: image

In the contract tool however, I can see that that contract is not owned by that character, but instead is owned by the Corporation: image

(same behaviour in the Tree view as well)

When including contracts in the asset windows (assets and tree) the owner should be set by the following logic:

If contract.Corporation == Yes then contract.IssuerCorp else contract.Issuer

looks like you tried something like that in the past, not sure why that would be commented out: image

Do you remember what issues you ran into here?

Thanks and best regards!

GoldenGnu commented 4 months ago

In jEveAssets the owner is the character/corporation that got the data, if you want the corporation to be the owner, you need to add a corporation account for the corporation in question. Luckily the corporation contracts endpoint doesn’t require any roles in the corporation and is available to all members.

However, if you actually have a corporation account for the corporation, then I will consider this a bug, as it should use the corporation contracts, for corporations.

Please, let me know if this resolves your issue or if it is a bug.

Wrong again! >_< This is a bug

GoldenGnu commented 1 month ago

Released in 7.9.1