search

GoldenGnu / jeveassets

jEveAssets is an out-of-game asset manager for Eve-Online, written in Java
http://eve.nikr.net/jeveasset
GNU General Public License v2.0
156 stars 38 forks source link

Use https were applicable #493

Closed salartarium closed 1 month ago

salartarium commented 1 month ago

Changed a few links to use https for speed and security

GoldenGnu commented 1 month ago

Thank you! 👍

Please add yourself as contributor in the following places: https://github.com/GoldenGnu/jeveassets/blob/main/src/main/java/net/nikr/eve/jeveasset/gui/dialogs/AboutDialog.java#L100 https://github.com/GoldenGnu/jeveassets/blob/main/credits.txt#L28 You can use your real name, an alias/eve name, or a combination of both.

You can either update this PR, make a new PR, or you can let me know what name you want added and I can do it for you.

salartarium commented 1 month ago

I believe I have successfully updated the PR ;)

GoldenGnu commented 1 month ago

Sorry, you merged the develop branch into the main branch, which we only do on release of the develop branch: Merge branch 'develop' into main That means I can't merge this PR, all your changes are good, except for that.

GoldenGnu commented 1 month ago

I'm going to see if I can somehow fix this

GoldenGnu commented 1 month ago

Manually merged in https://github.com/GoldenGnu/jeveassets/commit/863b74577187c33aa0c3873fa3ea1cd81575f99d

Thank you very much for your contribution! 🎉👍 Sorry for the complications!

GoldenGnu commented 1 month ago

Released in 7.9.1

salartarium commented 1 month ago

Saw this was merged on the forums! Sorry, for not responding. Kind of losing interest in the game. Thanks for dealing with my lack of IT skills. 😅

GoldenGnu commented 1 month ago

No worries! I'm happy it all worked out in the end. If you're on the jEveAssets discord or join at any point, be sure to PM me so I can give you the contributor role.