search

GoldenOwlAsia / react-native-twitter-signin

MIT License
167 stars 303 forks source link

TwitterKit -> TwitterKit5 #179

Open zimoo354 opened 2 years ago

zimoo354 commented 2 years ago

I've been working with this library for a couple of weeks now and I've been facing an issue when installing pods and I was able to solve it by making a change that's already made on the repo. I guess the package has not been updated in the npm network.

The issue I found is related to the TwitterKit that's being used in the package.

The podspec file have this:

s.dependency "TwitterKit", "~> 3.3"

and it should be

s.dependency "TwitterKit5"

Is this gonna be updated anytime soon? I don't think it's appropiate to be modifying files inside the node_modules folder

Naturalclar commented 2 years ago

Since this library seems to not have been updated in a while, I've created and published a fork that includes TwitterKit5 https://github.com/react-native-twitter-signin/twitter-signin

oisu commented 2 years ago

@Naturalclar Great work! You saved my day 🤗