Goldenfreddy0703 / Otaku

Repository for Otaku Development
GNU General Public License v3.0
114 stars 22 forks source link

[Feature] A setting to disable Unaird Episodes #156

Closed jaimsitecom closed 1 year ago

jaimsitecom commented 1 year ago

Hi again. Is it just me who has unaired episodes showing up or is there a settings option in the new version to hide unaired episodes?

I noticed this also after the recent version updates. I guess since 2-3 vesions ago. It used to be only what has been aired that shows up in the list.

TIA

Goldenfreddy0703 commented 1 year ago

Hey there, when we were improving episode meta for Otaku, we used simkl for episode meta which is why you see unaired episodes as well.

I noticed this also after the recent version updates. I guess since 2-3 vesions ago. It used to be only what has been aired that shows up in the list.

Yeah we use to have it do something like that when we had consumet and enime episode providers, Sense they shutdown, we use simkl now which shows unaired episodes.

jaimsitecom commented 1 year ago

Oh ok. So this is a permanent issue now?

jaimsitecom commented 1 year ago

I guess nothin we can do about. As long as otaku can play available episodes, i’m ok. Thanks for the explanation.

Goldenfreddy0703 commented 1 year ago

I guess nothin we can do about. As long as otaku can play available episodes, i’m ok. Thanks for the explanation.

Well we could probably do something about it cause our episode meta has airdates and all and we can try to make it where if it reaches that specific airdate then the episode will show.

We could probably make a setting for it and all, it will take time tho.

Do you think that could help so that it can be like our previous episode meta?

jaimsitecom commented 1 year ago

Cool! It’s always nice to have an option on every feature. Thanks again for all you guys are doing to maintain this great addon.

Goldenfreddy0703 commented 1 year ago

Hey so good news, next release will have an option called "Hide Unaired Episodes" in the General Category of the addon settings. When it releases, enabled the setting and rebuild database and see if that fixes it and then we can close this issue.

Goldenfreddy0703 commented 1 year ago

Hey release should be out in a min so im going to go ahead and close this issue but if problems do occur, pls feel free to open this issue and tell me if it worked for you.

Thank you

jaimsitecom commented 1 year ago

Woohoo! Great news indeed. Thanks so much.

I updated to the latest version, cleared cache, rebuild database, restarted kodi, ….WORKS LIKE A CHARM!!!

Thanks!!!

jaimsitecom commented 1 year ago

Hey release should be out in a min so im going to go ahead and close this issue but if problems do occur, pls feel free to open this issue and tell me if it worked for you.

Thank you

reporting a bug. After using the on/off feature showing unaired episodes, some shows show up as blank. As in no episodes showing up even if the episode was aired. For my case, jujutsu kaisen, rurouni kenshin, undead murder farce showed up blank when the ‘hide unaired episodes’ button is enabled. When i turn it on and rebuild the database, it goes back to normal and shows up all episodes (including unaired eps of course).

The feature worked the first time. But when i loaded up kodi the next day, it started to blank out most shows. Could it be connected to my turning on my Anlist account in watchlist? I am gonna tinker on it some more.

jaimsitecom commented 1 year ago

May i know if you guys in a middle of updating/fixing metas for anime shows? Some shows will show up their episodes but most would not when the ‘Hide unaired eps’ is turned on.

So i confirm that turning on the ‘HIDE UNAIRED EPISODES’ will also hide other episodes both aired and unaired, most shows will show up blank actually. I tried turning off my Watchlist in settings, no effect. Shows don’t show the aired and unaired episodes. When i turn off ‘hide unaired eps’, the shows will populated the episodes - including unaired episodes.

So i guess i have to TURN OFF the hide feature and accept that unaired episodes will stay for now. 😁

anyways, thank you again!

Goldenfreddy0703 commented 1 year ago

Ahhh I might have forgotten to implant a feature where it if the next episode releases or if it reaches that specific airdate, it should populate. Hopefully I can work on that soon.

Now about your first question, we have not worked on that unfortunately. We been busy thought the week and yeah, hopefully we can get to that soon.

jaimsitecom commented 1 year ago

Ahhh I might have forgotten to implant a feature where it if the next episode releases or if it reaches that specific airdate, it should populate. Hopefully I can work on that soon.

Now about your first question, we have not worked on that unfortunately. We been busy thought the week and yeah, hopefully we can get to that soon.

No rush. Take your time. Otaku works fine now that i turned off ‘hide unaired eps’. As long as i get to watch my shows now, i’m good!

thanks so much!

jaimsitecom commented 1 year ago

Well, i tried to check if this feature is working again. Unfortunately not. 😀 when the switch is on, all my favorite shows became blank. No episodes show up anymore. Whether aired or unaired, they don’t show up anymore.

I will have to live and accept unaired episodes showing up for now. You can remove the switch for now i guess. Ty anyways for trying.

Thanks!

Goldenfreddy0703 commented 1 year ago

Ahhh sorry I forgot to work on this, hopefully will try to look into it today.

jaimsitecom commented 1 year ago

Ahhh sorry I forgot to work on this, hopefully will try to look into it today.

Thanks a lot! If it’s too much of a hassle, it’s ok to remove it permanently. Not really a problem anyway. 😀

Goldenfreddy0703 commented 1 year ago

Hey @jaimsitecom, good news, we fixed it and also added a new setting as well. Im going to close this issue but release should be out so feel free to test it and if you encounter any more problem related to this, we will open this issue again and all.

Thank you

jaimsitecom commented 1 year ago

Works great now! All my shows showing up all aired episodes and hides future unaired episodes. So far so good. Thank you!

DaisyF8 commented 1 year ago

Sorry to nag. I have hide unaired enabled but for example unaired episode for Berserk of Gluttony or Shangri-La Frontier is showing in Next Up in MyAnilelist.

Goldenfreddy0703 commented 1 year ago

Ahh well we only made that option just for episode meta but not next up sense next up is very buggy. Me and my team will try to look into it.

Thank you

Gujal00 commented 1 year ago

Sorry to nag. I have hide unaired enabled but for example unaired episode for Berserk of Gluttony or Shangri-La Frontier is showing in Next Up in MyAnilelist.

Next-UP comes straight from myanimelist api call watching?next_up=true, if myanimelist is showing unaired episodes, it is the api issue, nothing can be done inside Otaku

hide unaired enabled is only relevant when looking into episodes under the Currently Watching or Plan to Watch sections

but not next up sense next up is very buggy

The is nothing wrong with NextUp inside the Otaku addon itself. The bug is when you start using from widgets

Goldenfreddy0703 commented 1 year ago

Oh....i didn't actually think it was an api issue with Mal sense Next up is basically when you play a show, it will automatically play the episode from the episode meta and create a playlist and all. My bad and thank you.

Gujal00 commented 1 year ago

Watchlist Next UP is not the same as playlist Next up popup towards the end. Watchlist Next up shows what are the next watchable episodes from all the shows you are currently watching

DaisyF8 commented 1 year ago

Thx for explaining. And also : WOW with all the recent progress. I really like Otaku as TMDBhelper player.