joezito129
commented
1 year ago I just pushed a fix for this let me know if it is fixed.
Closed Nuklear92 closed 1 year ago
joezito129
commented
1 year ago I just pushed a fix for this let me know if it is fixed.
Goldenfreddy0703
commented
1 year ago Heyyyy @Nuklear92, joezito has pushed a fix and we have made a release so go ahead and test that and tell us if this issue is fixed from your side. Im going to close this but if you have any questions, feel free to reply to us in this issue and we will respond and if this issue is not fixed, we will look further into it.
Thank you
Nuklear92
commented
1 year ago @joezito129 @Goldenfreddy0703 Yes! It's working perfectly now. Appreciate the time and work spent into fixing this issue. 💙
Goldenfreddy0703
commented
1 year ago Ok awesome thanks. Now we just need to know if issue #165 is fixed or not.
Nuklear92
commented
1 year ago @joezito129 @Goldenfreddy0703 Bad news guys. So, I've tried different season packs and they all showing all the episodes now. However, when I click on any of the episodes from the pack it will not play. I'll post a small clip showing the issue in action.
Hopefully, this is just an easy bug and you guys can get it working correctly. 👍
Maybe you guys can try caching a season pack and try for yourselves and see if you can recreate the same result in your end. It was my fault I previously didn't fully tested the fix. I just saw it was showing all of the episodes as previously it was not. However, I just disregard clicking on any of the episode itself to see if it would play and assumed it was fully fix just because it was showing all the eps. But, now that I actually went ahead and tried clicking one of the episodes it's not working. And it's just not ep.17. I tried others and none are playing. Also, tried caching a different Season Pack to see if that one in particular was bad or expired from the debrid service. But, all are having the same negative result.
Goldenfreddy0703
commented
1 year ago Hey @Nuklear92 from replicating the issue, it seems to work fine for me, There is a possible chance you may want to rebuild database, clear cache, and clear torrent cache, and restart kodi. Try that and see if you get the same result, also try a different batch torrent or something.
Edit: Nevermind it happens when you have select source enabled. Will need to fix that.
To Replicate the Issue, you need these specific settings enabled Playback > Movie Play Style > Source Select Playback > Episode Play Style > Source Select Playback > Terminate Cloud Sources > True Sort & Filter > Enabled Manual File Selection for Batch Torrents > True
Nuklear92
commented
1 year ago @Goldenfreddy0703 tried all of those options before doing that clip and that was my result. 😥
Nuklear92
commented
1 year ago I'll, try maybe reinstalling the addon completely and see if i get the same result. I'll report back in a bit.
Goldenfreddy0703
commented
1 year ago @Goldenfreddy0703 tried all of those options before doing that clip and that was my result. 😥 I'll, try maybe reinstalling the addon completely and see if i get the same result. I'll report back in a bit.
Made a quick edit, you don't have to do those steps.
Edit: Nevermind it happens when you have select source enabled. Will need to fix that.
To Replicate the Issue, you need these specific settings enabled Playback > Movie Play Style > Source Select Playback > Episode Play Style > Source Select Playback > Terminate Cloud Sources > True Sort & Filter > Enabled Manual File Selection for Batch Torrents > True
Goldenfreddy0703
commented
1 year ago For a workaround, have change the Movies or Episode Play Style to Auto Play until we have a fix for this.
Nuklear92
commented
1 year ago @Goldenfreddy0703 Just for reference I just finished reinstalling the addon and setting up everything completely, and still having the same result. So, there's definitely an issue going on that needs to be patch in order for manual selection to play the episodes successfully from Season Packs.
Edited: Tried your settings and got the same negative results.
In the meantime, I'll just keep selecting the links from the Source Select screen and remove the cloud storage season pack in order to skip that manual selection until you guys patch it up and then I'll double check again to confirm if it's fixed. 👍
Goldenfreddy0703
commented
1 year ago @Nuklear92 i sent you like a few things and made edits if you check the previous github messages.
Things i explained in my previous github messages:
You did not have to do those steps
I have replicated the issues and found out that this is caused by playing an episode with Source Select and having Manual File Selection for Batch Torrents turned on
Edited: Tried your settings and got the same negative results.
- Those were settings on how to replicate the issue, you did not have to follow them at all
Workaround:
Things I found when testing:
Summary: We have to make it where the Get Sources does not activate the get_best_match function when its getting Cloud Sources
Nuklear92
commented
1 year ago I see, well I'll just wait then until you guys make it work the correct way when having Playback: Source Select + manual batch selection + cloud source scraping ON. Just give me a mention and I'll try testing again to confirm it's working. 👍
I usually not a fan of having Auto Play because it's not always accurate to the specific files I like to play when it comes to resolution, audio tracks, etc Specially when there are a variety of them available.
Goldenfreddy0703
commented
1 year ago @Nuklear92 good news, me and @joezito129 came up with a fix for this so hopefully this will fix your issue. If you encounter any problems feel free to reply in here and we will look further into it.
Please tell us if this fixed your issue cause i feel confident that it is fixed.
Nuklear92
commented
1 year ago @Goldenfreddy0703 @joezito129 Yes! Now is working correctly. However, the difference seems to be it now bypasses the source scraping screen and the season pack will appear on top of the list. From there I just click on the pack and it will show all of the Episodes and when I click on the one that matches the show episode I'm scrapping it now plays correctly.
So, pretty much seems like a better fix of not popping up the season pack in the middle of the scrapping screen process, and instead wait until the scraping is done and you select from the Source Select UI. 👍
Thanks a lot guys for the quick fix! 💙
Goldenfreddy0703
commented
1 year ago However, the difference seems to be it now bypasses the source scraping screen and the season pack will appear on top of the list. From there I just click on the pack and it will show all of the Episodes and when I click on the one that matches the show episode I'm scrapping it now plays correctly.
Exactly, that's how it should do it instead of having the user select multiple times and having it show up during the getting sources screen. Glad it works, I was very confident that this would fix it, and also make it better. Huge thanks to @joezito129 for making this possible and improving on this.
Nuklear92
commented
1 year ago @Goldenfreddy0703 Definitely! This way seems more stable and correct. 😃
Thanks a lot to @joezito129 for the work and dedication being put into making this addon better and better. 💙
Okay, so I have my account with RD with the option to additionally scrape cloud storage in case I have a season pack saved for easy access.
Having the option for manual file selection for Batch torrents, will cause the Inspect Cloud Files on Scrape option to pop up a manual selection for the Episodes on the Season pack it finds on my RD cloud storage. However, it will only show one single random episode from the season pack instead of all of the episodes with the Season Pack.
I'll show screenshots below in chronological order so you can see the issue clearly.
As you can see from the screenshots in order. I selected Episode one for scraping, however it only shows one single random episode from the whole season pack Episode 5 to be specific.
The correct way it should be, showing the whole season pack and then I manually select the correct episode that matches the episode I'm scraping from the season which in this case is Episode 1. The problem happens with any episode, doesn't matter if it's 1,2,3, etc. just by having the Manual Batch selection ON and also having the Scrape files from cloud storage will always give this inaccurate results. Plus, never showing the whole season pack and just one single random episode from it.