Goldenfreddy0703 / Otaku

Repository for Otaku Development
GNU General Public License v3.0
114 stars 22 forks source link

Add option to hide next page button on widget view #191

Closed OdinIsLord closed 5 months ago

OdinIsLord commented 11 months ago

Hi, next page button can ruin your view on the Spotlight. An option to hide it would be nice.

ApplicationFrameHost_18veTnl7W1

Goldenfreddy0703 commented 11 months ago

Question, does seren have this option?

OdinIsLord commented 11 months ago

Didn't use Seren in ages but I just installed it to check and it does have the option.

kodi_aRR05LwPVb

Goldenfreddy0703 commented 11 months ago

Ok great, will see how serens option works and will try to make an option on Otaku for it.

Thank you

TwilightMercy commented 11 months ago

Also available in Fen if it helps

Goldenfreddy0703 commented 10 months ago

Hey so funny story, i looked at Serens code and my mind went blank due to how the widget detection works so this may take longer to add then i thought. Hopefully either @joezito129 or @Gujal00 can do this one.

OdinIsLord commented 8 months ago

@Goldenfreddy0703 I will go ahead and close this as not planned with your consent?

Goldenfreddy0703 commented 8 months ago

Heyy @OdinIsLord , this is still planned however, our contributors don't really use kodi skins and I'm still unsure on how widgets can be coded and all. If we could get help or if somebody can show me some documentation, I definitely will add this future.

OdinIsLord commented 8 months ago

Heyy @OdinIsLord , this is still planned however, our contributors don't really use kodi skins and I'm still unsure on how widgets can be coded and all. If we could get help or if somebody can show me some documentation, I definitely will add this future.

Good to hear. Wish I could help.

OdinIsLord commented 8 months ago

kodi_MCvKayvxS4 kodi_cwLsqw2EFC kodi_LmvQIlXaoM kodi_5rapI6px8y

Maybe the team would reconsider for the rest of us that use this beautiful add-on with skins.

theasguard commented 6 months ago

Heyy @OdinIsLord , this is still planned however, our contributors don't really use kodi skins and I'm still unsure on how widgets can be coded and all. If we could get help or if somebody can show me some documentation, I definitely will add this future.

seren\resources\lib\modules\list_builder.py seren\resources\lib\modules\globals for "g" seren\resources\settings.xml Line 132: next_args = params.pop("next_args", None) Line 161: not (g.FROM_WIDGET and g.get_bool_setting("general.widget.hide_next")) Line 166: if next_args: Line 167: g.REQUEST_PARAMS["action_args"] = next_args Line 174: menu_item=g.create_icon_dict("next", base_path=g.ICONS_PATH),

Line   48:              <setting id="general.widget.hide_next" type="boolean" label="30452" help="">
Goldenfreddy0703 commented 6 months ago

seren\resources\lib\modules\list_builder.py

seren\resources\lib\modules\globals for "g" seren\resources\settings.xml Line 132: next_args = params.pop("next_args", None) Line 161: not (g.FROM_WIDGET and g.get_bool_setting("general.widget.hide_next")) Line 166: if next_args: Line 167: g.REQUEST_PARAMS["action_args"] = next_args Line 174: menu_item=g.create_icon_dict("next", base_path=g.ICONS_PATH),

Line 48:

@theasguard can you actually try to code this setting in? That would be amazing if you could. 🙏

Thanks

theasguard commented 6 months ago

seren\resources\lib\modules\list_builder.py

seren\resources\lib\modules\globals for "g" seren\resources\settings.xml Line 132: next_args = params.pop("next_args", None) Line 161: not (g.FROM_WIDGET and g.get_bool_setting("general.widget.hide_next")) Line 166: if next_args: Line 167: g.REQUEST_PARAMS["action_args"] = next_args Line 174: menu_item=g.create_icon_dict("next", base_path=g.ICONS_PATH), Line 48:

@theasguard can you actually try to code this setting in? That would be amazing if you could. 🙏

Thanks

hey ill go over the code, dont get your hopes up quick though theses pys in seren are crazy, may take some time to figure out how it all goes together.

OdinIsLord commented 6 months ago

hey ill go over the code, dont get your hopes up quick though theses pys in seren are crazy, may take some time to figure out how it all goes together.

Thanks so much for looking into this. Wish I could help, yesterday Arctic Fuse got a huge fullscreen update and this feature is so needed now. Fingers crossed.

joezito129 commented 5 months ago

I added the setting on Otaku please test and let me know if it works for you.

Goldenfreddy0703 commented 5 months ago

Hey so we just made a release so hopefully this issue should be resolved. Huge thanks to @joezito129 for figuring this out.

OdinIsLord commented 5 months ago

I added the setting on Otaku please test and let me know if it works for you.

Works flawlessly, kudos!