Goldenfreddy0703 / Otaku

Repository for Otaku Development
GNU General Public License v3.0
114 stars 22 forks source link

Subtitles in French no way to change the source #200

Closed giventofly closed 10 months ago

giventofly commented 10 months ago

Hi, I been getting a problem of the video having french subtitles and there isn't a way to force a source video change, is this something to be implemented in the future?

Goldenfreddy0703 commented 10 months ago

Umm that's odd, were you using torrents or embeds. If embeds, what embed did you use? Did you edit subtitle settings and all to English and stuff?

giventofly commented 10 months ago

I just clicked to watch and it automatically selected the source, I have english set for subtitles

Goldenfreddy0703 commented 10 months ago

Weird, whats the anime and you may wanna go to context menu and select source so that way you can choose the source instead and see if other streams have french

Gujal00 commented 10 months ago

@giventofly Go to Settings-Provider tab and disable other language providers and only have multisub and your preferred language providers enabled

giventofly commented 10 months ago

It was mashle and dead mount death play, happened the same.

Will try the @Gujal00 suggestion later

icarok99 commented 10 months ago

Here it is normal even with all providers activated

Screenshot_2024-01-21-10-22-04-677_org xbmc kodi

Screenshot_2024-01-21-10-25-50-615_org xbmc kodi

icarok99 commented 10 months ago

@Goldenfreddy0703 @Gujal00 The only problem I found is if my Kodi has a Portuguese language and the subtitle preference is in English, the subtitle of the anime currently playing is in Portuguese.

icarok99 commented 10 months ago

This problem started with the update 0.4.60 I downloaded previous versions to check

Goldenfreddy0703 commented 10 months ago

This problem started with the update 0.4.60 I downloaded previous versions to check

Question, are you sure it was not 0.4.61 cause all those translations we merged kinda made it hard to work with at first.

Also if you guys were using aniwatch and had your regional settings set to Portugal then that could explain a lot sense gujal connected aniwatch with region.

Goldenfreddy0703 commented 10 months ago

@Goldenfreddy0703 @Gujal00 The only problem I found is if my Kodi has a Portuguese language and the subtitle preference is in English, the subtitle of the anime currently playing is in Portuguese.

One last question, what embed were you using, if aniwatch then that could explain alot.

m-spitfire commented 10 months ago

@Goldenfreddy0703 The only problem I found is if my Kodi has a Portuguese language and the subtitle preference is in English, the subtitle of the anime currently playing is in Portuguese.

One last question, what embed were you using, if aniwatch then that could explain alot.

I had the same problem, after disabling aniwatch, it seems to be finding subs in english instead of Portuguese.

icarok99 commented 10 months ago

This problem started with the update 0.4.60 I downloaded previous versions to check

Question, are you sure it was not 0.4.61 cause all those translations we merged kinda made it hard to work with at first.

Also if you guys were using aniwatch and had your regional settings set to Portugal then that could explain a lot sense gujal connected aniwatch with region.

Yes I'm sure it's version 0.4.60

Screenshot_2024-01-21-12-40-17-016_org xbmc kodi

icarok99 commented 10 months ago

@Goldenfreddy0703 @Gujal00 The only problem I found is if my Kodi has a Portuguese language and the subtitle preference is in English, the subtitle of the anime currently playing is in Portuguese.

One last question, what embed were you using, if aniwatch then that could explain alot.

Aniwatch, but the selected language preference was English

Goldenfreddy0703 commented 10 months ago

I had the same problem, after disabling aniwatch, it seems to be finding subs in english instead of Portuguese.

Ok awesome so looks like we should connect aniwatch with the subtitle settings instead of the regional settings that gujal did in the past.

Thanks for letting me know

Goldenfreddy0703 commented 10 months ago

Ok so @giventofly @icarok99 and @m-spitfire , i looked into it and made a couple of changes that should hopefully resolve your issue for any user that uses Aniwatch.

image Ok so i made a release that should have where Aniwatch subtitles will be based on the subtitles settings by default in the Playback Category. I have also added an option called Region Subtitles which sets Subtitles based on the Region your in.

Hopefully this should fix #200 but just encase, Please test the latest release that should be online and tell me if it works so we can close this issue.

Goldenfreddy0703 commented 10 months ago

Yes I'm sure it's version 0.4.60

I don't think so, we had Aniwatch for a long time where subtitles were always based by region if you were to change your region settings, Reason why we did this was cause Gujal coded it this way and it made sense to me. Around version 0.4.61, we introduced your translation changes which is probably why this issue was brought up so any version you choose will basically have this issue.

Also 0.4.60 was just embed extraction changes that did not bother with any embeds nor players so is shouldn't have been 0.4.60 at all.

icarok99 commented 10 months ago

@Goldenfreddy0703 With this update, the problem was resolved. Post can be closed.

Goldenfreddy0703 commented 10 months ago

ok awesome, now i just need to know @giventofly if he was using aniwatch or not. If he was then this problem was solved.

giventofly commented 10 months ago

Sorry for the delay, tested now and seems to be working perfectly. thanks

Goldenfreddy0703 commented 10 months ago

Awesome thanks