search

Goldenfreddy0703 / Otaku

Repository for Otaku Development
GNU General Public License v3.0
114 stars 22 forks source link

[Feature Request] Add toggle for disabling message "can't connect api myanimelist" #216

Closed DaisyF8 closed 9 months ago

DaisyF8 commented 9 months ago

Sometimes Myanimelist-site will go offline for a while and come back.

But I forget that this can be the cause, do re-auth and then curse "It's the site that's offline" harrrr!

Goldenfreddy0703 commented 9 months ago

Interesting, i mean we could possibly add a setting in the Mal watchlist settings that disables notifications but i don't think it would really be necessary cause if you had a setting to have the notification disabled, how would the user know if there anime is being tracked or not, wouldn't really make any sense.

DaisyF8 commented 9 months ago

It's not those notifications I would want to stop. It's purely the message "I can't connect to the MAL api" that is beside the point for me. For me it isn't a big deal MAL is down. It won't stop me watching an anime. And I know it's usefull to know that tracking is down.

But when I see the message (can't connect to API), there are two possibilities : either MAL is offline, or my authorization isn't working. And I always forget to first check if MAL is offline. I'd rather not see the "can't connect"-message. Seeing the message triggers me to retry the authentication. And when I do that while MAL is offline (most of the time this is the cause of the error), I can't do anything at that moment anyway.

A "Don't show connection errors" toggle in MAL-settings would solve this.

But that's just me, no worries. I justed wanted to let you know.

Goldenfreddy0703 commented 9 months ago

Ok I thought about it and you do have some points so going to add it soon, maybe tonight.

Thank you

Goldenfreddy0703 commented 9 months ago

Hey @DaisyF8 , added the setting so should release in a few min, im gonna go ahead and close this but please test and if you have any issues about this feature, feel free to reply in here and we will look into this further.

Thank you

DaisyF8 commented 9 months ago

Thanks so much for adding the feature. I'll let you know if I have news.