[Request] Add IMDb ID info tag

[TwilightMercy]

Hi,

I was wondering if you can add IMDb ID as info tags so these 2 parameters will get values: When not playing video - ListItem.IMDBNumber When playing - VideoPlayer.IMDBNumber

https://kodi.wiki/view/InfoLabels

As an example for these params set, you can look at Fen addon code in: plugin.video.fen\resources\lib\modules\player.py

This will help subtitles addons to find subtitles easier from Otaku's sources (with IMDb ID) Thank you very much!

[Goldenfreddy0703]

Hey so yeah, we do have some imdb id's in our database but it's not alot. We could try to add them but may not be as useful sense most animes you see don't have imdb id's unfortunately.

[TwilightMercy]

I would love to have it anyway if you can add 🙏🏻👌🏻

Edit: I found this issue, was that implemented since then? https://github.com/Goldenfreddy0703/Otaku/issues/149#issuecomment-1721928804

Imdb id for a4ksubtitles support for example

[Goldenfreddy0703]

Oh yeah we did add that, i guess i better add the database to it as well, just haven't done that sense its been awhile. Alright let me see if i can do it this afternoon. It was implemented but i believe we had to do api request in order to get it working, luckily we have a database so that should help with atleast some animes,

Yes it has been implemented but it has not used our database so will try to work on that today.

[Goldenfreddy0703]

Ok so good news, i found out a way to get the imdb_id and i made a function for it but only problem is idk where to put it in my code so this will probably take more time then i thought.

[TwilightMercy]

Ok so good news, i found out a way to get the imdb_id and i made a function for it but only problem is idk where to put it in my code so this will probably take more time then i thought.

Great to hear! Didn't you put here in the right place? By this commit change:

[Goldenfreddy0703]

Wait.....did I not put it in the right place, I thought I did

Edit: I did put it in the right place, it looks weird on github sometimes.

[TwilightMercy]

Are you able to send me zip file of the addon with the changes, so I can test it? (if IMDB ID is set in video playback / menu listing)

[Goldenfreddy0703]

Are you able to send me zip file of the addon with the changes, so I can test it? (if IMDB ID is set in video playback / menu listing)

Changes are on another branch if you would like to test it, these are the changes i made. https://github.com/Goldenfreddy0703/Otaku/commit/e15c262d09b2b841ab7cf5ff66941a60c0f8cd54

[TwilightMercy]

I've tested this branch's version, and unfortunately, I still don't see IMDb ID proprty value from: ListItem.IMDBNumber or VideoPlayer.IMDBNumber

[Goldenfreddy0703]

exactly which is why i need a place for that new function i added in the simkl.py file to help recognize that function correctly.

[TwilightMercy]

What so you mean recognize? The function doesn't run when video tags are set?

[Goldenfreddy0703]

I'm not too sure tbh, me and @Gujal00 looked into this yesterday and we had trouble with it so we are going to look into this further tonight. The function does run but for some odd reason the videotag is not being recognized and its odd.

[TwilightMercy]

Very weird.. the "setIMDBNumber" should work, just like other tags that are working (title/year/season/episode that I do see)

[Goldenfreddy0703]

Yeah but it's possible functions in wrong place, who knows, will get it figured out tonight

[TwilightMercy]

Hopefully good news? 😀

[Goldenfreddy0703]

Hey so good news, we manage to get the a4k subtitles to recognize the imdb id, we will release very soon so hopefully we should have this request completed. Only thing we just need to do at the moment is just fix the tmdb helper player sense we made alot of file changes to it and all.

[Goldenfreddy0703]

Heyyy so release should be out so hopefully it works very well for you. I'm going to go ahead and close but if you run into trouble with imdb, feel free to reply and we will open this up and look into it.

Thank you

[TwilightMercy]

Hi,

thank you very much for the update, I've tested it and IMDBNumber is set successfully on video playback and I see it's value, both through: VideoPlayer.IMDBNumber and VideoPlayer.UniqueID(imdb)

It works perfectly with a4k subtitles and other subtitles addons that are excepting IMDB ID.

My only request if possible (and if not, that's not that important): is to make the IMDb ID value set also through ListItem.IMDBNumber or ListItem.UniqueID(imdb) (when not playing video)

The reason is I have subtitle addon that can search subtitles through Kodi's context menu on selected list item, without playing the item. and the other info labels (such as OriginalTitle,year,etc..) are set successfully (except IMDB ID)

Screenshot example:

Thanks for everything!

[Goldenfreddy0703]

My only request if possible (and if not, that's not that important): is to make the IMDb ID value set also through ListItem.IMDBNumber (when not playing video)

I think I can do that in the next release so will see. Thx

Edit: I have no idea how to do this but if its easy to do, maybe @Gujal00 can do that.