Goldenfreddy0703 / Otaku

Repository for Otaku Development
GNU General Public License v3.0
114 stars 22 forks source link

Not showing all torrents #249

Open guybarner opened 6 months ago

guybarner commented 6 months ago

When I try to watch jujutsu kaisen season 2, I saw that I get much less sources than when i look in nyaa directly. It seems like when you guys scrap you do something like season 2, 2nd, s02 and some torrents only use the number of the total episode in this case 25, and you can't find result like that. For example episode 1 in jujutsu kaisen s2 You can't find kaizoku upload

Screenshot_2024-04-30-22-18-20-842_com github livingwithhippos unchained-edit

guybarner commented 6 months ago

Because of that problem you also can't search it in real debrid cloud, i guess because the name is the same. It think it will be call i you can add a manual search option so you can scrap nyaa with your own query, so stuff like that doesn't happen

Gujal00 commented 6 months ago

There is no episode 25, that is stupid tmdb numbering. As per the show producers, Jujutsu Kaisen was 24 episodes. Jujutsu Kaisen 2nd Season is a new show with 23 episodes starting from episode 1. Otaku follows anilist numbering which follows the japanese producer numbering so will only show torrents matching that. If Kaizoku uploading is following tmdb numbering, then you are better off with tmdb_helper + seren

guybarner commented 6 months ago

I will try to see if I can find solution because it not specifically kaizoku, when you try to scrap jujutsu kaisen season 2 you see that many torrents aren't there

guybarner commented 6 months ago

Also why not add tmdb id to the db, many torrents use it for their episode numbering

guybarner commented 6 months ago

Maybe try to use https://github.com/Fribb/anime-lists?tab=readme-ov-file Mapping, as it have almost every anime service

Goldenfreddy0703 commented 6 months ago

We actually have the tmdb ID, it's just the numbering and the season parsing thats the main problem cause we utilize an anime database and tmdb utilizes a global database.

guybarner commented 6 months ago

Oh so maybe another solution will be to get the season number and if it like season 2, and the first season has 24 just add the current episode and add them together like (24+1=25) so you will get to this episode number in addition to the S2EP1

guybarner commented 6 months ago

been looking for about an hour in the addon code to find solution. I will see if I got time to actually write the code for the solution but i am not sure what every request actually returns

guybarner commented 6 months ago

There is no episode 25, that is stupid tmdb numbering. As per the show producers, Jujutsu Kaisen was 24 episodes. Jujutsu Kaisen 2nd Season is a new show with 23 episodes starting from episode 1. Otaku follows anilist numbering which follows the japanese producer numbering so will only show torrents matching that. If Kaizoku uploading is following tmdb numbering, then you are better off with tmdb_helper + seren

About thay, that's not entirely true because for example jujutsu kaisen season 1 doesn't find vodes upload to nyaa. Although it suppose to because the torrent name is: [Vodes] Jujutsu Kaisen [BD 1080p HEVC] [Dual-Audio] [EngGerSub]

guybarner commented 6 months ago

You guys think there is anything you can do? @Goldenfreddy0703

theasguard commented 6 months ago

certain torrents have always been a odd problem its not new. examples tsukimichi season 2 most time returns eria raws, had troubles finding the dubs and duals, and others mashle season 2, same thing it had issues finding the single dubs and what not again lvl 2 cheat powers same thing problems finding the dubs and duels, not sure why to be honest. the scraper update that was reverted did fix a ton of that but it did have some problems on certain series itself. im sure something will be figured out i myself kept the scraper update because ive had search results for different items even as it was, which was fine.. thats my 2 cents

theasguard commented 6 months ago

image_2024-05-01_093752332 episode 8 and 10 it appears on not any other i could see.

theasguard commented 6 months ago

There is no episode 25, that is stupid tmdb numbering. As per the show producers, Jujutsu Kaisen was 24 episodes. Jujutsu Kaisen 2nd Season is a new show with 23 episodes starting from episode 1. Otaku follows anilist numbering which follows the japanese producer numbering so will only show torrents matching that. If Kaizoku uploading is following tmdb numbering, then you are better off with tmdb_helper + seren

About thay, that's not entirely true because for example jujutsu kaisen season 1 doesn't find vodes upload to nyaa. Although it suppose to because the torrent name is: [Vodes] Jujutsu Kaisen [BD 1080p HEVC] [Dual-Audio] [EngGerSub]

I'm still looking into the reason behind this bug, I believe it's something in the code, as I go over nyaa hopefully it'll fix that and grab the vodes season pack on the whole season not just 2 episodes, just keep in mind I'm not a magician so it may take some time especially since it's not like the other scraper addons, Thanks for being patient

guybarner commented 6 months ago

There is no episode 25, that is stupid tmdb numbering. As per the show producers, Jujutsu Kaisen was 24 episodes. Jujutsu Kaisen 2nd Season is a new show with 23 episodes starting from episode 1. Otaku follows anilist numbering which follows the japanese producer numbering so will only show torrents matching that. If Kaizoku uploading is following tmdb numbering, then you are better off with tmdb_helper + seren

About thay, that's not entirely true because for example jujutsu kaisen season 1 doesn't find vodes upload to nyaa. Although it suppose to because the torrent name is: [Vodes] Jujutsu Kaisen [BD 1080p HEVC] [Dual-Audio] [EngGerSub]

I'm still looking into the reason behind this bug, I believe it's something in the code, as I go over nyaa hopefully it'll fix that and grab the vodes season pack on the whole season not just 2 episodes, just keep in mind I'm not a magician so it may take some time especially since it's not like the other scraper addons, Thanks for being patient

You're amazing for doing anything at all. Thank you vary much for the hard work :)

Goldenfreddy0703 commented 6 months ago

Heyyy @guybarner we recently released a fix with the nyaa scrapper, did that solve your issue by anychance? If you could get back to me on that, that would be great. Thanks

theasguard commented 6 months ago

Heyyy @guybarner we recently released a fix with the nyaa scrapper, did that solve your issue by anychance? If you could get back to me on that, that would be great. Thanks

I believe this bug still exists for some titles from [vodes] seems some of their info is all messed up on nyaa itself, I'm going to look at a way to resolve this. But it did fix a ton so there is that.. Haha

Edit the episode info on nyaa mainly is the cause for certain [vodes] titles

Goldenfreddy0703 commented 6 months ago

Ahh ok thank you

guybarner commented 6 months ago

Heyyy @guybarner we recently released a fix with the nyaa scrapper, did that solve your issue by anychance? If you could get back to me on that, that would be great. Thanks

It looks like most of it is fixed other than the ones when they have the accomulated number of the episode in place of the season number and episode number of that season (ep47 -> s2 ep13) stuff like that. But I guess this problem is not with scrapping but more of the anilist database. I just want to say again thanks for all the hard work :)

theasguard commented 6 months ago

i fixed the [Vodes] bug all be it is a temp fix as i go through code more i might find something thatd be messing with the retrieval process

Heyyy @guybarner we recently released a fix with the nyaa scrapper, did that solve your issue by anychance? If you could get back to me on that, that would be great. Thanks

It looks like most of it is fixed other than the ones when they have the accomulated number of the episode in place of the season number and episode number of that season (ep47 -> s2 ep13) stuff like that. But I guess this problem is not with scrapping but more of the anilist database. I just want to say again thanks for all the hard work :)

i fixed the [Vodes] bug today all be it, it is a temp fix as i go through code more i might find something thatd be messing with the retrieval process of certain titles.

you're partly right its more of a naming / id issue, across several platforms, being an anime addon the way we retrieve sources is slightly different compared to say Fen or Seren, and anime just have messed up numbering, that doesnt work right with lets say fen, as i adjust everything we should hopefully solve any odd bugs. hope this helps you understand. thanks for the patience

guybarner commented 6 months ago

Thank you for the effort, take as long as you need :)

guybarner commented 5 months ago

@theasguard maybe look at what torrentio does, because it look like they catch stuff like that( maybe the code from the stremio addon, it has GitHub page )