search

Goldenfreddy0703 / Otaku

Repository for Otaku Development
GNU General Public License v3.0
114 stars 22 forks source link

[Feature Request] Smaller intervals in filtering by size #263

Closed Sickhead01 closed 6 months ago

Sickhead01 commented 6 months ago

Currently when setting a maximum or minimum size limit on torrents I can only increase/decrease at a minimum of 1GB. I want to set a minimum limit of 500MB but that's impossible and 1GB is way too much. photo_2024-05-21_15-00-56

Goldenfreddy0703 commented 6 months ago

I knew somebody would complain about that eventually, yeah later tonight I will have minimum file size by decimal instead so it's similar to what how Seren has it.

As a workaround, have it go by internet speed and it will have it automatically adjust it for your liking.

Goldenfreddy0703 commented 6 months ago

Hey so i went ahead and added Smaller intervals in filtering by size, will have this release tonight. Im going to go ahead and close this but if you have any questions or concerns, please feel free to reply and we will open this back up and look further into this.

Thank you

Sickhead01 commented 6 months ago

Yeah so, Thanks for adding my request. I appreciate your hard work but the size filter setting is bugged. I set my minimum episode size to 0.5 GB and max to 300MB. It works as intended on some shows but on others it doesn't do anything at all or does the opposite of what it's supposed to and filters out everything except torrents smaller than 500MB

photo_2024-05-21_23-50-51 photo_2024-05-21_23-46-50 photo_2024-05-21_23-46-51 photo_2024-05-21_23-52-37

Goldenfreddy0703 commented 6 months ago

Yeah so, Thanks for adding my request. I appreciate your hard work but the size filter setting is bugged. I set my minimum episode size to 0.5 GB and max to 300MB. It works as intended on some shows but on others it doesn't do anything at all or does the opposite of what it's supposed to and filters out everything except torrents smaller than 500MB

Hey so from doing some testing, i tested multiple Animes and episodes and it seems to be working for me just fine but i do notice that you said that you set your max to 300mb which can't be possible cause i have the file selection set in gb, not mb and we based the filtering by size off of Seren where its going by gb. I can probably add an option to filter in mb instead or have max size use decimal or maybe have a custom field where the user can enter the number. I will have a look into this tomorrow and see what i can do.

image

Sickhead01 commented 6 months ago

Oh the MB was a typo for the maximum. It's in GB. The highest it can go, 300GB

Goldenfreddy0703 commented 6 months ago

Oh then wait I'm confused, ok so what do you have your settings on and what is it supposed to do exactly?

Sickhead01 commented 6 months ago

I have the episodes and movie max size set to 300GB, and min set to 0.5GB, and the results are ere as seen in the images above, ie, not filtering out the 250MB torrents, or in the case of Ragna Crimson filtering out everything EXCEPT the 250MB torrents

Goldenfreddy0703 commented 6 months ago

Ok I see now, will look into that today, thanks for explaining.

Goldenfreddy0703 commented 6 months ago

Hey so i just made a release so hopefully it should fix this bug. Thank you noticing this, apparently this was a long time bug and no one has noticed. So what happened was apparently gb and mb were not being converted which was why you had issues with the minimum size, again thank you for noticing this and hopefully this should fix it.

If you do have any other issues with this, please feel free to reply again and we will look further, Thank you