search

Goldenfreddy0703 / Otaku

Repository for Otaku Development
GNU General Public License v3.0
114 stars 22 forks source link

Add 480p max resolution #279

Closed Eskander closed 5 months ago

Eskander commented 5 months ago

Hello! Thank you for maintaining this great addon.

Could you please add a setting for 480p max resolution? It's useful for conserving metered data while watching on phone/tablet.

Goldenfreddy0703 commented 5 months ago

This is a first time hearing someone wanting 480p anime, we probably could but im not sure if there are torrents or embeds out there that even support 480p, we have 360p but not sure if that will help.

Eskander commented 5 months ago

Yeah I'm sure the use case is quite uncommon. 360p helps too, but it's not currently selectable in max resolution settings (lowest is 720p). I suggested 480p since there are embeds with said quality, and failing that it would fallback to 360p anyway.

Goldenfreddy0703 commented 5 months ago

Ohhh wait, 360p is NA, It should have been SD, if you don't mind. Try NA and see if that works. If not then I will look into this more.

Eskander commented 5 months ago

That indeed worked, thank you!

Somewhat related, but I noticed that InputStream embeds don't follow Otaku's max resolution setting, they follow InputStream Adaptive settings instead. Is that a known behavior?

Goldenfreddy0703 commented 5 months ago

Yea it is cause embeds run very smoothly with InputStream Adaptive. Back then they use to be buggy for some odd reasons especially with playback. Thanks to InputStream Adaptive, we got those bugs fixed.

Eskander commented 5 months ago

Alright, thanks for your help.

Goldenfreddy0703 commented 5 months ago

Hey so i took this into account and i decided instead of having NA, i decided to add 480p and EQ into our options of resolutions and there were some improvements and fixes a discovered when doing this.

Thank you for making this Feature Request.

Eskander commented 5 months ago

Thank you for looking into this! I gave it a try, and while 480p works as expected, it's not quite clear what EQ quality means. From looking at the code I understand that it corresponds to 576p, is that correct? And if so, is it standard to note 576p as EQ?

Goldenfreddy0703 commented 5 months ago

EQ quality most likely means Embed Quality so that way you can you can't find embed qualities your looking for, you can always try EQ quality.