Goldenfreddy0703 / Otaku

Repository for Otaku Development
GNU General Public License v3.0
107 stars 21 forks source link

Update for Dubbed Fonts #313

Closed antoniem34 closed 1 month ago

antoniem34 commented 1 month ago

For now, the addon only has the option to choose between Japanese and English in the settings.

But there are already many multi-audio sources, which include several languages, but unfortunately we cannot choose them automatically from the addon.

These sources are usually identified with the words Multi-Audio.

Example:

image

Goldenfreddy0703 commented 1 month ago

Hey so your actually able to choose multisub sources by going to the Sort & Filter settings and by enabling the prioritize multisubs option.

Now from your examples, I actually didn't know that people just name Multisubs by "Multi" so gonna have to add that as a keyword.

As for the Dubed Fonts in your title, I'm actually confused by it but if you want to change the subtitle font, that's a kodi setting thing, not an Otaku thing.

Does this help?

antoniem34 commented 1 month ago

Hi, the example with the image is so you can see that there are more sources for the Audio, currently the Addon only allows you to choose between English and Japanese, the idea is that you can also add the other languages ​​as options in the Audio.

The 3 options that I sent you for titles are taken directly from the page, so you can see how they usually name the sources, they are just examples, nothing to do with content obtained in the addon.

antoniem34 commented 1 month ago

image

Here it would be good if you could include or add Multi-Audio not just Dual-Audio

image

Here you can also choose the Audio preference, which is more than just Japanese and English, (Spanish (Latin American), German, English, Spanish (European), French, Indonesian, Italian, Japanese, Portuguese (Brazilian), Thai)

antoniem34 commented 1 month ago

The selection in the addon works well, as well as when used with Kodi's preference, only that for example in my case if there is a source that has the audio in Spanish I prefer it, but generally the ones that are Dual will have preference and not the ones that are Multi, I have managed to filter them with the terms on occasions, but since the way they are usually named changes, it is not always filtered in the best way.

Sorry if I don't make myself understood, I use Google Translate

Goldenfreddy0703 commented 1 month ago

Mmmmm....ok I see what you mean, we could probably add more languages to it but a long time ago, I had a reason why I only had it to English or Japanese and that probably had to do with either figuring out if subtitles should be enabled or not or something with dual audio sources. I don't remember exactly but I could probably add more languages maybe. The only downsides with this is that most of the embeds and anime torrents don't even offer other audio languages, mostly English and Japanese torrents and I never seen any torrents that have Multi-Audio which is interesting from your screenshot. Ok do basically the only torrents you will most likely see if it was a different audio language is duel-subs and multi-audio.

Goldenfreddy0703 commented 1 month ago

image

From your image I can also add Multi Audio, I didn't even know that was even a thing.

antoniem34 commented 1 month ago

If many sources appear on Nyea, I usually do some research on that page before I create filters in Sonarr, so I can choose the sources that I know have audio in different languages

https://nyaa.si/?f=0&c=0_0&q=Multi-Audio

Sometimes they only have 2 even if they say multi-audio, but usually they tend to have several additional languages.

antoniem34 commented 1 month ago

In general, the sources that have multi-audio also have several subtitles, and I think they are usually taken from CrunchyRoll and also from some Platforms like MAX there is an uploader called Nandesuka that uploads a lot in several languages ​​or [ToonsHub] among others.

Goldenfreddy0703 commented 1 month ago

Heyyyy so i made a release that should add Multi Audio so tell me if it works out for you but if not, tell me what animes that have multi audio so i can test them and everything.

As for the audio language, i did not work on that cause i just remembered why i only set it to eng or jpn and that reason is cause of sub and dub sources where if the user selected eng then dub sources would play english audio without subtitles, if the user wanted jpn then the sub source would play jpn audio without the subtitle, if the source was a duel audio then it would select the audio you picked but if eng or jpn was not one of them, it would probably default to the first one if im correct. I will still look into it more in the future and all and see what i can do.

Im gonna go ahead and close this but if issues still occur, feel free to reply and we will open this back up and look further. Thank you

antoniem34 commented 1 month ago

Sorry I didn't reply, I didn't find the message thread.

I tried this but it still works the same, besides the fact that the groups don't usually name the anime correctly, that is, in some cases even if it has more than 2 languages ​​they don't name it correctly.

Almost all the anime that is from sources like CrunchyRoll, MAX or Star, usually has several languages.

Your Dub solution takes them all, so Multi-Audio or Multi-Dub is not necessary.

What would be good if you could is to be able to include more words in the filters part, so we can include several terms, for better filtering.

I usually go to nyaa.si to verify the torrents, so I know which sources work best with my tastes, such as those that contain any of the following terms, Latin Dubbing, Spanish Dubbing, ESP, SPA-LA or SPA, Multi-Audio, HMAX, MULTI, NANDESUKA, ZIZZAG among others.

Anyway, thank you for taking the time to review our requests.