Goldenfreddy0703 / Otaku

Repository for Otaku Development
GNU General Public License v3.0
114 stars 22 forks source link

having a plugin category ($INFO[Container.PluginCategory]) for skinners to identify if a Movie or TV Shows #363

Open hcgiub001 opened 1 week ago

hcgiub001 commented 1 week ago

Hey Goldenfreddy0703, thank you for such an amazing anime addon. The more I use it the more I'm in love. In Nimbus (skin) when I'm in the Movies section , It shows as TV Shows

image

I've asked the Developer of Nimbus (ivarbrandt) about this issue to correctly display the correct category and this was the response

What's missing there in Otaku is a plugin category. This is what Nimbus uses to display that kind of information. It pulls it using this infolabel $INFO[Container.PluginCategory].

If the information you want is stored in a different infolabel, I can add that in

do you know if that information is available? thank you for any help :)

Goldenfreddy0703 commented 1 week ago

Hey there, I'm not too sure but I'm sure @Gujal00 does know. As for the category showing tv shows, we actually have both movies and tv shows but reason why the category says tv shows is cause we had to set it like this due kodi limitations cause in an anime database such as anilist, the movies and tv shows are combined which is why we had to do it like this. If there was an Anime Catagory. That would be amazing.

But again, sense @Gujal00 knows the info labels, I'm sure he can answer your question.

hcgiub001 commented 1 week ago

thanks for quick response, I now realise why it would be hard to have one category across the board. I'll wait to see Gujal00's response but if their is nothing that can be done then it's okay. thankyou :)

jewbmx commented 1 week ago

Im not sure if it would be passed to the skin but i think everything in the addon is handled by the tag "mediatype" or "media_type" in the addon. The issue could also be from the directory content type being set as addons for everything but im not actually sure about that lol.

joezito129 commented 1 week ago

Im not sure if it would be passed to the skin but i think everything in the addon is handled by the tag "mediatype" or "media_type" in the addon. The issue could also be from the directory content type being set as addons for everything but im not actually sure about that lol.

All the contenttypes are set to tvshows in the draw_items function if no contentType is passed. You need to add a contenttype movies when processing movies.

jewbmx commented 1 week ago

Yea thats pretty much where my brain went too, its addons or tvshows or episodes but not movies in content types. but the mediatype info label is passed thru out the addon and it looks like it might be able to be used for your skin if you try pulling it lol. Likely easier to modify the addon instead of the skin tho lmao.

joezito129 commented 1 week ago

I dont think there is anything wrong with the skin it seems like it is getting the correct information from otaku, just its being set wrong in otaku

joezito129 commented 1 week ago

also i dont think it has anything to do with mediatype. the content type is wrong

hcgiub001 commented 1 week ago

also i dont think it has anything to do with mediatype. the content type is wrong

thanks for everyone's help, is their something that can be done?

joezito129 commented 1 week ago

change the contentType to 'movies' instead of 'addons' for movie sections.

jewbmx commented 1 week ago

I think if mediatype is included in the stuff sent to the spot that content type is set you could add a little swap there using mediatype as the decider, altho i think the visual aspect is all thats wrong with this situation so its more like a flaw instead of a issue lol. As for content type being used i think addons is used for menus like normal then tvshows or episodes for everything else due to them situations where the movie items are designed like a show with the movie item being episode 1 or whatnot. All this leads me to think the lazy fix idea might be best but i dont know the whole code structure so i could be wrong.