search

Goldenfreddy0703 / plugin.audio.ytmusic.exp

Experimental Youtube Music for kodi created by Foreverguest
22 stars 3 forks source link

Fix json decoder exception and catch VideoUnavailable #3

Closed woernsn closed 2 years ago

woernsn commented 2 years ago

There is a problem catching the JsonDecodeError within pytube. I couldn't find the problem as the actual thrown exception is indeed a JsonDecodeError but isn't caught. The more-generic ValueError is caught though, so I changed it within the the pytube code - we should think about that once we upgrade pytube again. Referencing https://github.com/pytube/pytube/issues/1190.

Also, I caught the VideoUnavailable exception which was a reason for error messages popping up here and there.

In addition, I removed the Donation part of the README.md as the link is not existing any longer.

woernsn commented 2 years ago

:heavy_check_mark: Tested successfully on Ubuntu 21.04 / Kodi 19.3.0 :heavy_check_mark: Tested successfully on Raspberry Pi 3B+ / LibreElec 10.0.2 / Kodi 19.4.0

Goldenfreddy0703 commented 2 years ago

Hey, thank you so much for fixing the json decoder exception and catch VideoUnavailable. I will go ahead and merge your PR and I will also give you the permission to read and write on this project when I get home soon.

Again, thank you for contributing and your the best.