search

Goldenfreddy0703 / plugin.audio.ytmusic.exp

Experimental Youtube Music for kodi created by Foreverguest
22 stars 3 forks source link

Playing 'My Supermix' crashes after 2 or 3 songs #31

Closed Habitual-Sinner closed 1 month ago

Habitual-Sinner commented 10 months ago

Hey, As per title, my supermix crashes kodi after playing 2 or 3 songs.

I'll post logs when it does it again.

I know that you've been looking for help maintaining the addon, I'm by no means a dev but have worked in IT for nearly 20 years and I'd be happy to try and lend a hand if I can.

fischcode commented 10 months ago

Hi I haven't had problems with the addon crashing Kodi so far: What is contained in 'My Supermix'? What version of Kodi are you using?

Habitual-Sinner commented 10 months ago

Hi, My Supermix is basically a YouTube curated playlist that spans all of your tastes.

It could possibly have something to do with crossfading enabled for songs not on the same album in Kodi. I'll test it some more later and post logs.

Kodi 20.2 Linux, YTmusic Beta19 (I'll test on beta 20 that you just released)

Habitual-Sinner commented 10 months ago

I've had a chance to test with the latest version and it plays fine with cross-fading disabled but still crashes Kodi with it enabled. I've attached a debug log but it doesn't really show much Kodi crash with crossfading.txt .

fischcode commented 10 months ago

Thank you very much for the clarification. I can easily think of ways how crossfading could interfere with the functioning of the addon. Unfortunately I am unable to reproduce the issue with Kodi 20.2 on Windows - while a 10 s setting for crossfading (with songs on the same album enabled) has a distinct effect when playing music from a file source, the setting seems to have no effect whatsoever when playing songs, albums or playlists with the ytmusic.exp addon (still have to test on LibreElec): What are the exact crossfading settings you are using? Do you get a crossfade effect when playing the first few songs of your playlist before Kodi crashes?

Habitual-Sinner commented 10 months ago

I appreciate you following this up, thanks. I have it set to 8s (crossfading songs on the same album disabled).

Some songs have a distinct gap at the beginning and/or end of a song but I definitely do get the effect when it works. Forcing the addon to load the next song early isn't really something that it was designed to do, it's just something that I like having enabled if I'm listening to a playlist of random music and is a functionality that the actual YouTube Music App doesn't have (even though I can see it's a feature that's been asked for a lot online) So again, I appreciate you taking the time.

fischcode commented 8 months ago

I am very sorry but I am still unable to reproduce your problem. Having found out that I need to select audio instead of video streams for crossfading to work with the ytmusic addon, various playlists play fine with crossfading enabled, both on Windows and with Kodi 20.2 on Linux Mint 21.2 Cinnamon: Is there anything special about the songs in your playlist (e.g. a very short song or the like)?

Habitual-Sinner commented 8 months ago

Hey mate,

Travelling at the moment so unable to test further.

I'm sorry that I didn't specify that I had YTmusic set to audio in order for crossfading to work, I'll be back home tomorrow so can provide more information then.

On Tue, Jan 9, 2024, 03:26 fischcode @.***> wrote:

I am very sorry but I am still unable to reproduce your problem. Having found out that I need to select audio instead of video streams for crossfading to work with the ytmusic addon, various playlists play fine with crossfading enabled, both on Windows and with Kodi 20.2 on Linux Mint 21.2 Cinnamon: Is there anything special about the songs in your playlist (e.g. a very short song or the like)?

— Reply to this email directly, view it on GitHub https://github.com/Goldenfreddy0703/plugin.audio.ytmusic.exp/issues/31#issuecomment-1881770593, or unsubscribe https://github.com/notifications/unsubscribe-auth/AED25CPNXBQ77S5BPPEW7BDYNRJAVAVCNFSM6AAAAABAE6DMSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRG43TANJZGM . You are receiving this because you authored the thread.Message ID: @.*** com>

fischcode commented 1 month ago

Issue closed as I have been able to run YTMusic.exp with audio only and crossfading enabled for a long time without any problems: Could it be that the issue is related to a particular playlist? If so, try to create a public playlist with the same behaviour or provide a list of songs which can be used to create a playlist which is affected by the issue.