Closed TaiDak closed 2 years ago
I’ll take a look at this stuff eventually.
For when I do get to it eventually, can you provide examples of anime for each issue?
@TaiDak Can you provide examples for issues 2 and 3? I have a solution for number 1 already, but am waiting to push it until I can look at the other issues.
@jkaw Ok, so I got confused, fanart does work for anime in romaji pretty good, I don't know why it wasn't working good before
Issue 3 only affects AniList watchlists. If you have title language set to English in the add-on settings, your watchlist might not open if you have some specific anime in your list. I thought it was because they had no English title equivalent, but I don't think that's the case anymore. I went through my entire list and these anime specifically create an error that doesn't let you open your watchlist
If I set title language to romaji, the watchlists open normally. https://paste.kodi.tv/ipibotutef My log
@TaiDak
You were correct. The anime you listed all had no english title equivalent. The issue is this weird Python thing that I've seen twice now. The dictionary get() function is supposed to have a definition that takes two arguments, one being the key for the item you want, and the other being the value you want to return in case the key doesn't exist in the dictionary. It seems that when item.get(key, item.get(differentKey)) is given, it never returns the item.get(differentKey) when item.get(key) is None. I have to basically split that two argument method into an if/else.
So to summarize: Issue 1 should have been fixed in #25 Issue 2 seems to not be an issue anymore Issue 3 should be fixed in #26
You should be able to test Issue 1 in the current beta. Issue 3 will be testable whenever #26 is merged and a release is made. Please let me know if these issues are fixed for you so I can close this.
Tested your commit, it works perfectly
Just a few bugs that I've seen as of beta 18
Those three are the only major issues I've encountered so far, although I can get somewhat around them.