Goldenfreddy0703 / plugin.video.kaito.beta

A New Beta Version of Kaito made by SwagOtaku
GNU General Public License v3.0
7 stars 1 forks source link

Mark As watched not working #29

Closed MAR2196 closed 2 years ago

MAR2196 commented 2 years ago

Hello, when attempting to mark an episode as watched, the screen will load for a bit but will not actually mark the episode as completed. This wasn't an issue in the previous versions of Kaito prior to 0.0.11. For the record, I do not use any watchlists such as mal. Attached is a video of the issue.

https://user-images.githubusercontent.com/106176223/170093131-16d3bb18-4c37-4d4f-851c-d173fd3bb6d4.mp4

Let me know if there's anyone else having this issue as well. Thank you for the hard work, I appreciate it!!

jkaw commented 2 years ago

Can you check your Kaito context menu version? It might not have updated. The one from the Hooty Repo is the correct one that should have fixed the mark as watched for non watchlist users.

You can also check the source select context menu. If it is the old version, it will auto play instead of showing sources

MAR2196 commented 2 years ago

I just ran a fresh install. I had the correct context menus in both cases. Source select works fine but not mark as watched. Tested on both my desktop and fire tv.

jkaw commented 2 years ago

Ok, so I remember I never fixed that, only the select sources thing. I think it would take a while to fix this mark as watched issue. SwagOtaku changed all of the paths of the urls for almost every action, and now the regular kodi database is having a hard time relating a play count with the new paths. I'll take a look, but in the meantime, you may want to just try to use one of the integrated watchlists...

jkaw commented 2 years ago

There is an option to use the old kaito menus actually that I recently implemented. You can access them through Settings/General. At the bottom there is a Use Kaito 10 Menus option. You will have to do a rebuild database after.

I just checked and the mark as watched function is working there. I reimplemented those menus due to speed issues on slower devices, so some fanart and episode images may not work, but the episode info should all work.

MAR2196 commented 2 years ago

Great, thank you for looking into it! I'll most likely switch to using an integrated watchlist, I just figured I'd post the issue here to keep track of it. Thanks for all of your efforts, I appreciate it!!

jkaw commented 2 years ago

I just made a pull request that will fix this if you don't have the Watchlist Update setting enabled. I just assume if you have an integrated watchlist you wouldn't want a watchlist that can't be synced to your devices anyway. I'm open to creating a whole new setting for it though.

jkaw commented 2 years ago

Also, it turns out it wasn't the changed paths from SwagOtaku that broke it, but rather the new list builder. Apparently it just won't work with the default 'mark as watched' context menu due to using the addDirectoryItem function.

jkaw commented 2 years ago

@MAR2196, the release should be out with a fix for this. Please let me know if this issue has been fixed for you, so I can close it.

MAR2196 commented 2 years ago

Hey @jkaw, this issue has been fixed! I will be switching over to an integrated watchlist now. Thanks!