Goldenfreddy0703 / plugin.video.kaito.beta

A New Beta Version of Kaito made by SwagOtaku
GNU General Public License v3.0
7 stars 1 forks source link

scraper results hard to read - shadow background and line highlighting missing after 0.0.11.29 #48

Open meesterexx opened 2 years ago

meesterexx commented 2 years ago

Tested this on 0.0.11.29, .31 & .36. Scraper results are had to see now. Tested on Arctic Horizon 2 and Arctic Zephyr 2 resurrected.

See screenshots below

0.0.11.29: screenshot00001

0.0.11.31 & .36: screenshot00000

Goldenfreddy0703 commented 2 years ago

Oh that's not good, could you tell me which skin is used for each screenshot? I know you used Ah2 and Az2 but idk which screenshot goes to which skin.

Goldenfreddy0703 commented 2 years ago

ok so im testing 0.0.11.36 on Ah2 and im not getting that bug where its hard to see. image Let me see Arctic Zephyr 2 resurrected.

Goldenfreddy0703 commented 2 years ago

Would you mind telling me what device your using, usually linux devices can be buggy.

meesterexx commented 2 years ago

They are both from AH2. I first noticed it in AZ2R, so I went to check in AH2 to rule out a skin issue . When in happened in AH2, I started updating kaito in reverse (I keep several versions of the addon zip archived) until I hit .29 and the issue went away. So I think you should be able to test in either skin.

Windows 11/Kodi 19.4. Maybe it got introduced by updating several versions of Kaito. Let me try with a fresh install.

Goldenfreddy0703 commented 2 years ago

true, try also following my troubleshooting steps if you haven't already. Im working on a new script to automatically update my repository so that could be in effect to this issue.

meesterexx commented 2 years ago

It still did it from from a clean install on AH2. So I started with a completely empty new kodi (no addons or userdata folder), only Estuary. Installed Kaito from your repo, authorized RD, put in my fanart api, set it to source select and still got the issue. I also tried it a second time with gogo and season part scraping disabled (I've had slow downs with those on in the past). Didn't make a difference.

From estuary: screenshot00000

meesterexx commented 2 years ago

Downgrade to .29 immediately fixes the issue. I didn't even have to clear cache or rescrape. I haven't diffed the xml files, but there's obviously a change somewhere, the .29 screenshot doesn't have the clearlogo above the results, only the kaito raven logo, the .36 does have the clearlogo.

On Estuary: screenshot00001

Gujal00 commented 2 years ago

@meesterexx can you go into settings and select "white" for the theme and test screenshot00000

Goldenfreddy0703 commented 2 years ago

Hey @Gujal00 , i just tried it with the white theme and it shows correctly for me. image

meesterexx commented 2 years ago

Lol, that was an easy fix. Thanks!!

screenshot00002

Goldenfreddy0703 commented 2 years ago

oh, wired, i guess i should have tried my troubleshooting steps before changing the theme to white.

Gujal00 commented 2 years ago

@meesterexx can you now switch back the theme to coloured and test again, it should continue to work. Seems to be a Kodi bug with default settings in settings.xml

meesterexx commented 2 years ago

Yes, it stayed fixed switching theme back from white to coloured . Nice!

Goldenfreddy0703 commented 2 years ago

Oh ok, it was just a glitch then.

meesterexx commented 2 years ago

Could it have something to do with the fact that <setting id="general.icons">Coloured</setting> wasn't in the settings.xml in userdata in previous versions and it's not initialized properly in the settings file until you toggle it once?

Gujal00 commented 2 years ago

Correct, Kodi is supposed to populate the default value mentioned in the addon settings.xml. However it is not doing it and hence the issue

meesterexx commented 2 years ago

My "broken" AH2 install looks like this before toggling: <setting id="general.icons" default="true">40389</setting>

Then I toggle to White in the addon: <setting id="general.icons">White</setting>

Then I toggle to Coloured: <setting id="general.icons">Coloured</setting>

Gujal00 commented 2 years ago

Yes, it supposed to populate the value of label 40389 from strings.po, instead it is populating the label id itself. For e.g, this line in settings.xml <setting id="titlelanguage" type="labelenum" label="40369" lvalues="40370|40371" default ="40370"/> sets the language Similarly this line is supposed to set the theme <setting id="general.icons" type="labelenum" label="40388" lvalues="40389|40390" default="40389"/> but not happening for some reason

Edit: Yes seems to be a Kodi bug. if you never go into the settings after a fresh install, kodi is populating label numbers instead of values. So there will be issues with titlelanguage, contenttype, general.icons and general.audio. They are all being set to the label numbers in the settings.xml

<settings version="2">
    <setting id="titlelanguage" default="true">40370</setting>
    <setting id="contenttype.menu" default="true">40305</setting>
    <setting id="general.icons" default="true">40389</setting>
    <setting id="general.audio" default="true">40315</setting>
meesterexx commented 2 years ago

Ok, thanks for all the help and the explanation, much appreciated!