search

Goldenfreddy0703 / plugin.video.kaito.beta

A New Beta Version of Kaito made by SwagOtaku
GNU General Public License v3.0
7 stars 1 forks source link

fix issue where romajii language users get wrong series && Add proper scraping for one piece/detective conan #5

Closed jkaw closed 2 years ago

jkaw commented 2 years ago

fixing zambux's bug. You can set language to romajii and it should now search for the english title on trakt and get the proper episodes Before it was searching the japanese title only which trakt does not handle nicely

jkaw commented 2 years ago

Also added code to improve scraping for one piece and detective conan. Was only going to do one piece ,but figured detective conan has a similar number of episodes.

TaiDak commented 2 years ago

Sorry for bringing this up, but cached episodes for one piece don't show up for me, unless I manually add them to my debrid cloud.

jkaw commented 2 years ago

Yes I just ran into that myself. I have a fix for it right now. Definitely weird. Seems like anilist did something because it worked before.

TaiDak commented 2 years ago

Testing the betas, works perfectly in beta 10, beta 11 breaks something.

jkaw commented 2 years ago

Yeah, I had to fix something. Anilist did something recently to their aliases and I had to change the code @Goldenfreddy0703 is preparing a release now.

If you want to know the details, for romajii users, it was searching trakt with the romajii name, so it was breaking. I had to add code to use an english name provided by an alias field. Before, it was returning (One Piece) (One Piece) as the alias. It now only returns (One Piece). Before my catchall code was just pulling the second item after doing a split. now it checks for an empty string.

jkaw commented 2 years ago

@TaiDak new beta is out with fix. Redownload the repo, install the beta, and let me know. It should be fixed now.

TaiDak commented 2 years ago

@jkaw yeah, one piece on beta 17 doesn't show any sources apart from gogo embeds

jkaw commented 2 years ago

Yeah, that one was my fault. It was late and I was being lazy. Should be fixed in latest when it gets released.

TaiDak commented 2 years ago

Don't worry man, appreciate all the work, I'm just a tester.