search

Goldinium / StreamHub

An interactive movie database
MIT License
0 stars 0 forks source link

StreamHub Github project #21

Closed Goldinium closed 1 year ago

Goldinium commented 1 year ago

Hello

This is Microverse JS capstone project There are two students/contributors

@Pi1998 @Goldinium

And this is the Github project link https://github.com/Goldinium/StreamHub/projects/1

Olamarx commented 1 year ago

Hi @Goldinium,

Good job so far, indeed you have spent time on this project! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

mckent05 commented 1 year ago

Hi @Goldinium,

STATUS: APPROVED ✔️ ✔️

Your project is complete! There is nothing else to say other than... It's time to start your capstone :shipit: Congratulations and well done! 🎉 approved

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.