search

GoldpawsStuff / AzeriteUI5

Custom user interface suite for World of Warcraft. Design and code by Lars Norberg and Daniel Troconis.
https://www.patreon.com/GoldpawsStuff
Other
23 stars 7 forks source link

[Feature] Hide Nameplates along with rest of UI for even more Immersion #47

Closed AdvLeon closed 11 months ago

AdvLeon commented 11 months ago

Game Flavor

Dragonflight

Is there an existing issue for this?

Describe the bug

First of all I just want to say thank you for extending compatibility with Immersion and allowing Unit Frames to be hidden. I have however noticed that Nameplate health bars are still visible.

To reproduce

Immersion add-on loaded - enabled fade UI when in dialogue. Enabled nameplates in AzeriteUI. Tested by disabling all add-ons except AzeriteUI and Immersion.

Expected behavior

Nameplate should be hidden.

Screenshots

downloadfile(1)~2

Additional context

Confirmed using latest version.

Goldpaw commented 11 months ago

Nameplates aren't parented to the UIParent frame which the rest of the UI lives in, it is parented to the WorldFrame. And thus wouldn't be hidden by Immersion, as that only modifies the opacity of the UIParent frame.

Are you sure Immersion hides the default blizzard plates?

Goldpaw commented 11 months ago

I tried with nothing but the default Blizzard UI and Immersion enabled. Nameplates still show when the rest is faded out.

So this is not a bug, and since we can't change what frame the nameplates are parented to (blizzard restriction), this isn't a feature I wish to implement either.

Screenshot from 2023-10-26 13-39-29

Screenshot from 2023-10-26 13-39-31

AdvLeon commented 11 months ago

I tried with nothing but the default Blizzard UI and Immersion enabled. Nameplates still show when the rest is faded out.

So this is not a bug, and since we can't change what frame the nameplates are parented to (blizzard restriction), this isn't a feature I wish to implement either.

Screenshot from 2023-10-26 13-39-29

Screenshot from 2023-10-26 13-39-31

Fair enough. Thanks for looking into it 😃

Goldpaw commented 11 months ago

Having that said, I'm not opposed to the feature. Might be some hackish ways I can make my nameplates piggyback on the UIParent's opacity changes without actually messing with their own opacity, weird as that might sound.

You know what, I'm re-opening this as a feature request and giving it a try! Worst thing that can happen is that I don't get it working, and we're there already! :D

Goldpaw commented 11 months ago

hah! Nameplates fading when Immersion says so fram the next update! :D

Screenshot from 2023-10-27 15-25-38

Screenshot from 2023-10-27 15-25-43

AdvLeon commented 11 months ago

Whoa that's amazing! Thank you so much for your persistence! 🙏🤩

Goldpaw commented 11 months ago

Added in 5.2.119-RC.