GoldpawsStuff / AzeriteUI5

Custom user interface suite for World of Warcraft. Design and code by Lars Norberg and Daniel Troconis.
https://www.patreon.com/GoldpawsStuff
Other
23 stars 7 forks source link

[BUG] <title>drop frames 5.2.141-RC #55

Closed mizone closed 9 months ago

mizone commented 9 months ago

Game Flavor

Dragonflight

Is there an existing issue for this?

Describe the bug

drop frame during combat

To reproduce

drop frame during combat ——>2 fps

Expected behavior

No response

Screenshots

No response

Additional context

drop frame during combat ——>2 fps

Goldpaw commented 9 months ago

There was a huge actionbutton taint bug in 5.2.141-RC, I fixed that in 5.2.142-RC today.

If that's not the issue, I would assume the fps drop is a result of the other bug you reported: #56

The other bug apparently fires at aura updates, and that can really drop the framerate as there are a LOT of them. But I need more info to fix it. See my comment on #56

mizone commented 9 months ago

I downloaded the files and replaced AzeriteUI in Addon, it reported a lot of errors. thus, i can not test the changes. Waiting for your offical update version for test, and then feedback.

mizone commented 9 months ago

when I use 5.2.137, no FPS drop issue. I think it related the content your updated in verison 5.2.141

mizone commented 9 months ago

5.2.142-RC, still show very bad performance, still drop FPS. fps drop to 5

WoWScrnShot_121323_225627

below is a normal one, fps=57

WoWScrnShot_121323_225339

mizone commented 9 months ago

5.2.143 was tested. it still drop fps to around 20 in combat.

Goldpaw commented 9 months ago

It's probably the bug in #56 that's causing it. In a raid the event that's calling it fires a LOT, like possibly hundres of times a second. A bug there can cripple the UI. Fix coming today.

mizone commented 9 months ago

much better, but still drop frames, not as smooth as the version 5.2.136, during combat. please check

Goldpaw commented 9 months ago

much better, but still drop frames, not as smooth as the version 5.2.136, during combat. please check

A little hard for me to test since my laptop can only ever run the game around 35-55 frames per second, and that is always consistent. I don't have the hardware to check these things.