search

GoldpawsStuff / Bagnon_ItemInfo

Adds item levels, bind status, and garbage desaturation to bagnon all in one, with less overhead than using multiple addons.
https://www.patreon.com/GoldpawsStuff
MIT License
5 stars 2 forks source link

Bagnon 8.2.29 messed with the garbage plugin #6

Closed Nillx closed 4 years ago

Nillx commented 4 years ago

8.2.29 Now, if no plugins like Bagnon Scrap are installed, marks sellable gray items with the default junk coin icon.

At first the garbage plugin seems to be working fine but if i hover over a grey item it starts showing a gold icon in th e top left corner. If i close my bag and open it again its not showing unless i hover over it again.

LudiusMaximus commented 4 years ago

The Bagnon changelog of 8.2.29 says: Now, if no plugins like Bagnon Scrap are installed, marks sellable gray items with the default junk coin icon.

I guess this is the problem here.

Goldpaw commented 4 years ago

This garbage part of this plugin tones down and desaturates garbage items. That is working as intended. Bagnon now follows the default UI behavior in regards to the junk icon, meaning it's visible while at a vendor, hidden otherwise. That was the same behavior the garbage part of this plugin had. That too, is working as intended.

If you're using bagnon scrap in addition to this, any bugs are a result of that. Bagnon Scrap highlights junk items, this one tones them down. Obviously they can't be used together.

No bugs on my end. Closing this.

LudiusMaximus commented 4 years ago

Sorry, but I beg to differ. Just tried it with only Bagnon and Bagnon ItemInfo activated and it is still like the OP describes it.

If Bagnon is run on its own, the coin is always shown for scrap items, not just while at vendors. This is apparently the way Bagnon is intending it to be now.

If you activate Bagnon ItemInfo on top, the coins only become visible after once hovering over the item.

Nillx commented 4 years ago

made a quick video example: https://www.youtube.com/watch?v=aY_j65gL8Ws

When i disable ItemInfo the garbage icon is always visible.

Goldpaw commented 4 years ago

Ok, I see the problem here. I didn't realise there had been a bagnon update two days ago, I was testing with the version from December 26th. The latest update to bagnon was ofc ONLY to this!

So no wonder everything was working as intended on my end... I used the old version my plugins were written for, lol! SORRY! :D

Goldpaw commented 4 years ago

And yeah, totally my bad here. The bagnon version was written in the issue title, even. Should have been obvious to me.

Goldpaw commented 4 years ago

Fixed in 1.0.13-Release, should be available on Twitch and CurseForge soon!