search

Golf-Drill-Challenge-App / Golf-App

7 stars 0 forks source link

Gehrkej/ Stroke Error Handling #277

Closed Gehrkej closed 2 months ago

Gehrkej commented 2 months ago

Changes:

This PR introduces error handling for the strokes input and confirms that it is a positive integer.

Related Issues: #276

Screenshots:

image image image

FrankreedX commented 2 months ago

I noticed that we now have 3 different error check functions for the input form and it’s likely there’ll be more so let’s standardize the names. Maybe “check + [thing we’re checking]”?

solderq35 commented 2 months ago

Not that it matters because it's the same value in the end, but inputs like "2.0", "2.000" etc. go through without any warning message

image

solderq35 commented 2 months ago

Jake offered to add this readme typo fix to this PR.

Issue: https://github.com/Golf-Drill-Challenge-App/Golf-App/issues/278