GollyGang / ready

A cross-platform implementation of various reaction-diffusion systems and PDEs.
GNU General Public License v3.0
761 stars 60 forks source link

Crash when changing some formula rules to double type #101

Closed timhutton closed 3 years ago

timhutton commented 3 years ago

e.g. GrayScott1984/parameter-map.vti

Where the formula declares things as float4 this will usually cause problems because the compiler doesn't like to automatically cast double4 to float4. And in fact Ready currently crashes because we don't catch exceptions from changing the data type.

To maintain the flexibility of being able to change the data type we would need to either:

Related: Do we want to be able to change the block size too? Would be useful to change it to 1x1x1. Nvidia is moving to a scalar architecture, I've read. Is good to keep this flexibility in mind.