This fixes #132. The override issues have been fixed with later versions of VTK, and only clang picks them up, so a good fix is to suppress the warnings only for clang with older VTK. It's important to keep these override warnings for other cases.
Also fixed some genuine issues that Clang picks up, like missing overrides, unused variables, function hiding.
Removed -Wno-nullability-completeness-on-arrays on Apple builds. Not sure if we've fixed the underlying issues or if the config on our CI builds doesn't show it up but it looks like we no longer need that flag.
This fixes #132. The override issues have been fixed with later versions of VTK, and only clang picks them up, so a good fix is to suppress the warnings only for clang with older VTK. It's important to keep these override warnings for other cases.
Also fixed some genuine issues that Clang picks up, like missing overrides, unused variables, function hiding.
Removed
-Wno-nullability-completeness-on-arrayson Apple builds. Not sure if we've fixed the underlying issues or if the config on our CI builds doesn't show it up but it looks like we no longer need that flag.