GollyGang / ready

A cross-platform implementation of various reaction-diffusion systems and PDEs.
GNU General Public License v3.0
766 stars 60 forks source link

Minor: Split normals where contour hits boundary #47

Closed timhutton closed 4 years ago

timhutton commented 4 years ago

The current contour surface has been given averaged normals everywhere, giving strange rendering effects like the black ring visible here on the right: image We don't want to allow the automatic splitting that comes with vtkPolyDataNormals which would sometimes give creases inside our surfaces. But we do want split normals on the boundary, always.

Source code where the capping happens: readybase/ImageRD.cpp L888

timhutton commented 4 years ago

Now looks much better: image

danwills commented 4 years ago

Awesome work fixing that Tim! It looks so much better now, great improvement! :D