Closed timhutton closed 3 years ago
Wow Tim you've been busy! Bloody awesome work mate!
I am super keen to check all of this out, and I'll also try to make sure that the Houdini importer can load all the updated formulas correctly.
I was about ready to commit a new version in a branch, but will fold any changes from this in as well.
@danwills Will these changes cause problems with the Houdini importer? I hadn't thought about that.
It's all good @timhutton I expect most things that used to work in the plugin probably still will but I might be able to extend (or 'fix') support for the new things formula mode can now do. That should vastly extend the number of things that can be imported as well, so definitely a worthwhile effort I reckon! :)
If you're happy with the changes I wouldn't want to hold up this pull request due to rdyHoudini (especially considering it's currently in a broken state for Houdini 18.5 anyway!).
I would love to preview this branch though, I'll checkout the trunk and apply this pull request later on, and hopefully give this branch a bit of testing for you : )
bilaplacian_a
,trilaplacian_a
,gaussian_a
,sobel_ne_a
,x_gradient_a
,y_gradient_a
,z_gradient_a
,gradient_mag_squared_a
(and similarly for the other chemicals). Several patterns have been converted from kernel rules to formula rules as a result:x_pos
,y_pos
andz_pos
, giving the cell location in each direction, in the range [0,1]. This allows a neater and more accurate way of implementing parameter maps. Previously rules would do e.g.hpos = index_x / X
which would give the 4x1x1 block position, not the cell position.dx
is now reserved for controlling the grid spacing of the Gaussian, Laplacian, bi-Laplacian, tri-Laplacian and gradient stencils. Formula rules no longer need to write e.g.laplacian_a / (delta_x * delta_x)
and can just writelaplacian_a
since the value ofdx
is used in the stencil computation.neighborhood_range
andneighborhood_weight
parameters in the XML format for the<rule>
node are no longer supported. Not much of this was implemented and it doesn't do what we wanted. The intention was to allow the same formulas to work on meshes as well as images with different stencils but it wasn't the right approach - it doesn't allow us to use e.g. a laplacian and bilaplacian in the same formula.This closes #87