search

Golob-Minot / geneshot

MIT License
28 stars 5 forks source link

Trimgalore #73

Closed jgolob closed 3 years ago

jgolob commented 3 years ago

Addresses issue requesting the addition of TrimGalore in place of cutadapt. Also does a bit of tidying (moves combine reads into the preprocessing module) and addresses the import warnings.

sminot commented 3 years ago

I took a look at the commits, and this looks great to me!

sminot commented 3 years ago

Feel free to merge it in, @jgolob! Up to you if you want to squash or not, it's all the same to me.

jgolob commented 3 years ago

@sminot I may wait to push this to master until the bugs in the corncob code are also fixed. If you do not have time to dig into this, that's fine and just merge to master with these changes and we can open a new issue.