search

GolosChain / Qa

3 stars 1 forks source link

Add tool for executing cli_wallet commands. #24

Open AKorpusenko opened 6 years ago

AKorpusenko commented 6 years ago

Description :red_circle:

@maslenitsa93 and I decided, that adding tool for executing cli_wallet commands like bash scripts would be greate. As we run can pass commands list to cli_wallet and it would execute them one by one like in interactive mode and return the same json response for any command, it would be ok to let golos-test user to write tests in cli_wallet way :slightly_smiling_face:

maslenitsa93 commented 6 years ago

Too simply implementation. It runs a whole script. Couldn't we run it command-per-command with responses? It even don't returns any response (it may be string where to find for key-phrases). Also possible problems with escaping. You do not tested it (because you do not used it in any place).

AKorpusenko commented 6 years ago

I've tested it enough. There are no problems with escaping. If you have any -- please leave an example. Well, adding line by line execution is a nice idea. Working on it.

maslenitsa93 commented 6 years ago

@AKorpusenko Returning of response is more required than all another. Do it at first, please.