search

GolosChain / golos

Socio-economic mediablockchain
https://developers.golos.io
Other
59 stars 36 forks source link

Figure out what is broken in tests with TODO or FIXME labels #437

Closed AKorpusenko closed 6 years ago

AKorpusenko commented 6 years ago

Cpp files to look at:

  1. block_tests.cpp
  2. operation_tests.cpp
  3. operation_time_tests.cpp

Find out whats wrong with some tests

AKorpusenko commented 6 years ago

List of errors in operation_time_tests.cpp:

  1. nested_comments1: FIXED

  2. comment_payout1: Fails at line: auto bob_comment_reward = get_last_operations( 1 )[0].get< comment_reward_operation >(); Log: 399452ms th_a operation_time_tests.cpp:522 test_method ] 10 assert_exception: Assert Exception static_variant does not contain a value of type golos::protocol::comment_reward_operation {"t":"golos::protocol::comment_reward_operation"} th_a static_variant.hpp:316 get

  3. feed_publish_mean: Fixed resize_shared_mem mehtod in database_fixture.cpp. Fails at line: BOOST_REQUIRE(feed_history.current_median_history == feed_history.price_history[(i + 1) / 2]); Log: operation_time_tests.cpp(1268): fatal error in "feed_publish_mean": critical check feed_history.current_median_history == feed_history.price_history[(i + 1) / 2] failed Reason: feed_history.current_median_history = 1010 99000 feed_history.price_history[(i + 1) / 2] = 1000 99000 where these numbers are asset's base and quote

  4. convert_delay: FIXED

  5. liquidity_rewards: FIXED

  6. comment_freeze: FIXED

  7. sbd_price_feed_limit: FIXED

  8. steem_inflation: Log: critical check gpo.current_supply.amount.value == new_supply.amount.value failed