Closed nicktrn closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git āļø
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nuxt-graphql-request | ā Failed (Inspect) | Sep 12, 2023 11:07am |
So hyped to see this! Will try out next week and looking forward to paying out the bounty!
@drewbaker Happy to see the enthusiasm!
Had a chance to try this yet? Did quite a bit of testing myself and included additional test instructions above. Will be unavailable for most of next week, so would be great to finalise this ASAP.
@nicktrn planning on getting into this week actually. Sorry about the timing. This was a big blocker on us using Nuxt3, so we have some catching up to do in terms of just moving from Nuxt2 to Nuxt3.
Having said that, I'm not even sure how to test this? Never tried to install a PR before. Also, any tips on how to use this in a Nuxt3 project? Probably need to update the readme.
Would love to have your email for future projects BTW. Email me drew@funkhaus.us please.
For local testing, you could clone my fork and switch to the nuxt-v3 branch:
git clone https://github.com/nicktrn/nuxt-graphql-request.git
cd nuxt-graphql-request && git checkout nuxt-v3
Or, if you have already cloned this repo, you can do this:
git fetch origin pull/53/head:nuxt-v3
git checkout nuxt-v3
Then just pick your poison from the "How to test" section above.
Using this in a Nuxt 3 project is straightforward. There's a working playground.
Specifically, have a look at https://github.com/nicktrn/nuxt-graphql-request/blob/nuxt-v3/playground/nuxt.config.ts and pages/index.vue. Config is identical to current, and usage nearly so, bar some v3-related changes such as useAsyncData
and useNuxtApp
.
If you have any questions just let me know, will be able to have a look over the weekend or early next week. Speak to you then.
Are there any updates on the progress so far? This may be the only module in the client that works properly.
Hey @awdr74100, should all be working. Would be great if you could test this locally!
My current plan is to publish my fork on NPM unless @Gomah shows up in the next couple of days.
Thank you @nicktrn for this PR, looks great, I just tested it locally šš»
Happy to merge & publish it when the docs are up to date, I don't have much time to tackle it at the moment
That summoning spell worked a treat - thanks for testing! Will ping you when the docs are ready.
Docs are ready! @Gomah
Updated all code blocks to SFC Composition API syntax and fixed a dependency issue on nuxt generate
.
Thanks @nicktrn, having a look now, should release soon āš»
I've tried my best to stick with the simplicity of the original module.
Breaking changes:
graphql-request
exports are now available fromnuxt-graphql-request/utils
instead as importing directly from module entry points is no longer allowed.New features:
Fixes:
Please give it a spin and let me know where it breaks!
How to test
Some options here:
yarn test
yarn dev
to experiment in playgroundyarn prepack
and add to existing Nuxt project via file import, e.g.yarn add "../nuxt-graphql-request"
yarn pack
and add to Nuxt project viayarn add <path_to_module.tgz>
I have had unexpected results using
yarn link
, so this method is not recommended.Fixes #52 /claim #52