GonVas / tickerrain

Website that displays in real time tickers being processed by different sources.
MIT License
179 stars 56 forks source link

Dockerizing environment #2

Open entrpn opened 3 years ago

entrpn commented 3 years ago

Hello GonVas,

Nice project. I wrote a Dockerized environment if you are interested in merging it or creating a branch out of it.

I have attached the patch file.

patchfile.zip

GonVas commented 3 years ago

Thanks I will look into it

granthoff1107 commented 3 years ago

@entrpn I was just going to open an issue for this :). How do I run the patch file?

GrantHoffman commented 3 years ago

I've create a PR from etrpn's branch to yours here: https://github.com/GonVas/tickerrain/pull/6

entrpn commented 3 years ago

Thanks @GrantHoffman, I realized that in get_stream_posts I added my username and password for the throwaway account that I'm using to run this program. I since changed my password lol.

Also FYI - I'm modifying my fork to focus on penny stocks so the patch would be better than pull request from my fork.

entrpn commented 3 years ago

@granthoff1107 you should clone this repo. download the zip file, unzip it and then run

git apply patchfile

I should have named the file better but that should work. The readme has steps to run it but basically:

docker-compose --env-file ../.env up --build

Your .env file should have the following:

REDDIT_CLIENT_ID=<your-reddit-client-id>
REDDIT_SECRET=<your-reddit-secret>
REDDIT_USERNAME=<your-reddit-username>
REDDIT_PASSWORD=<your-reddit-password>

hope that helps.

granthoff1107 commented 3 years ago

Thanks, this will help deployment alot

On Tue, Feb 16, 2021, 3:29 AM Juan Acevedo notifications@github.com wrote:

Thanks @GrantHoffman https://github.com/GrantHoffman, I realized that in get_stream_posts I added my username and password for the throwaway account that I'm using to run this program. I since changed my password lol.

Also FYI - I'm modifying my fork to focus on penny stocks so the patch would be better than pull request from my fork.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GonVas/tickerrain/issues/2#issuecomment-779672061, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFQZHJ73GC5YKYOI6BYP5TS7IUFZANCNFSM4XTL4RCQ .

alexferrari88 commented 3 years ago

@entrpn I have tried to apply the patch as per your instructions, but I got:

patchfile:11: trailing whitespace.
- First, install Docker.
patchfile:46: trailing whitespace.

patchfile:63: trailing whitespace.

patchfile:76: trailing whitespace.

patchfile:158: trailing whitespace.
                         username = username,
error: patch failed: process.py:21
error: process.py: patch does not apply
entrpn commented 3 years ago

@alexferrari88 I think those are warnings. If not take a look at this https://stackoverflow.com/questions/14509950/my-diff-contains-trailing-whitespace-how-to-get-rid-of-it

alexferrari88 commented 3 years ago

Surely the first one, I meant the last error

On Mon, Mar 1, 2021 at 5:23 PM Juan Acevedo notifications@github.com wrote:

@alexferrari88 https://github.com/alexferrari88 I think those are warnings. If not take a look at this https://stackoverflow.com/questions/14509950/my-diff-contains-trailing-whitespace-how-to-get-rid-of-it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GonVas/tickerrain/issues/2#issuecomment-788080404, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALWB5WXLYYUNDSRX72BGM73TBO5QZANCNFSM4XTL4RCQ .

entrpn commented 3 years ago

@alexferrari88

trygit apply --reject --whitespace=fix ~/Downloads/patchfile

You'll get some stuff that doesn't get merged. You'll need to manually merge those changes.

teacoat commented 3 years ago

I agree with this ticket, should be a bit easier to get running