TheWebTech
commented
4 years ago sincere apologies for my being slow. Ideally we want to use the same code base for both versions of the extension. I tested this version in chrome to see if chrome is still okay with it.
Unfortunately it throws an error in the manifest at the browser specific manifest settings.
Based on this post https://www.smashingmagazine.com/2017/04/browser-extension-edge-chrome-firefox-opera-brave-vivaldi/
I wonder if replacing all instances of chrome.xxx namespaced items (like chrome.tabs), with browser.xxx would enable it to work without needing the gecko manifest piece.
The other changes all should be fine.
This pull-request will cause errors in Chrome, since it uses a parameter in the manifest which Chrome doesn’t recognize.
Your checklist for this pull request 🚨Please review the guidelines for contributing to this repository.
[] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Do not pull request to Master please.(when in doubt request Develop branch) [] Test to make sure your feature/bugfix doesn't break other features ;) [] Write a meaningful description of what your changes are. [] Wait patiently and celebrate, you've submitted changes to the extension!
Description Please describe your pull request.
<3 Thank you!