search

GonzaloTorreras / HubSpot-Developer-Extension

A Chrome Extension for HubSpot Developers
https://chrome.google.com/webstore/detail/hubspot-developer-extensi/gebemkdecnlgbcanplbgdpcffpdnfdfo
37 stars 27 forks source link

fix weird issue with vw units on popUp load #239

Closed GonzaloTorreras closed 3 years ago

GonzaloTorreras commented 3 years ago

Your checklist for this pull request 🚨Please review the guidelines for contributing to this repository.

[?] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Do not pull request to Master please.(when in doubt request Develop branch) [X] Test to make sure your feature/bugfix doesn't break other features ;) [X] Write a meaningful description of what your changes are. [X] Wait patiently and celebrate, you've submitted changes to the extension!

Description This should fix the width issue with Chrome v91. It closes #238 bug

<3 Thank you!

GonzaloTorreras commented 3 years ago

@TheWebTech If you don't mind checking with me would be happy to discuss pull request workflow and future publishing

TheWebTech commented 3 years ago

Hey this is awesome Gonzalo. I was trying a similar fix but wasn't able to get it to work reliably. I'll give your code a test. Also I'll DM ya on Slack :)

TheWebTech commented 3 years ago

Before merging, You need to increase the version number here - it's a requirement of the Chrome web store.

https://github.com/TheWebTech/HubSpot-Developer-Extension/blob/ee942d1eed283e42d7d02a0e6136037cdc7ea918/manifest.json#L4

The important part to Google is just that the version number increases.

In order to make it clear what versions meant I was using semantic versioning. Basically it just means that the decimals in the number have meaning. MAJOR.MINOR.PATCH,

MAJOR version when you make changes that are not backwards compatible. (there's no backward versions in chrome so I'd just treat this like if you do a redesign, or a significant batch of updates. For example Google wants Manifest V3 eventually and that'd be worth incrementing this over since a lot of files will be touched.) MINOR version when you add functionality in a backwards compatible manner. This is basically what you'll do the majority of the time. PATCH version when you make backwards compatible bug fixes.

No ones going to yell at ya if you don't perfectly follow that. No one really looks at extension versions anyways.