search

GonzaloTorreras / HubSpot-Developer-Extension

A Chrome Extension for HubSpot Developers
https://chrome.google.com/webstore/detail/hubspot-developer-extensi/gebemkdecnlgbcanplbgdpcffpdnfdfo
37 stars 27 forks source link

[fix] PortalID is not correctly read and generates a wrong dev menu on the header #240

Closed GonzaloTorreras closed 3 years ago

GonzaloTorreras commented 3 years ago

Your checklist for this pull request 🚨Please review the guidelines for contributing to this repository.

[?] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Do not pull request to Master please.(when in doubt request Develop branch) [X] Test to make sure your feature/bugfix doesn't break other features ;) [X] Write a meaningful description of what your changes are. [X] Wait patiently and celebrate, you've submitted changes to the extension!

Description Please describe your pull request.

<3 Thank you!

Minor fix for the Menu developer on the header not being properly generated (the portal ID wasn't filtered correctly). I simplified the method to dependent from the Settings links, and doing a local link /{{slug}/{{portal}}/... instead, double-checking if HTTP(S) && qa/local/app.hubspot.com Can someone from HS check if doesn't break for Hubspoters that use it? @TheWebTech @williamspiro @drewjenkins?

TheWebTech commented 3 years ago

I will test this tonight, thanks for fixing!