search

GonzaloTorreras / HubSpot-Developer-Extension

A Chrome Extension for HubSpot Developers
https://chrome.google.com/webstore/detail/hubspot-developer-extensi/gebemkdecnlgbcanplbgdpcffpdnfdfo
33 stars 26 forks source link

Upgrade manifest v3 #245

Open GonzaloTorreras opened 2 years ago

GonzaloTorreras commented 2 years ago

No mayor update on background seems to be required for the V3 manifest. Jon do you mind taking a look if it works properly on mac?

I had to disable GA tho, that would require some re-work. But I couldn't find at the moment a good solution (the only workaround seems to set a Google app/API connection)

TheWebTech commented 2 years ago

Really cool that it seems GA was the main problem to solve here. I've read through the code. I didn't see anything that seemed problematic but will do my due diligence to actually test it on my mac so we can be sure. Awesome work Gonzalo.

TheWebTech commented 1 year ago

tested json formatter. Seems to work well.

Some indentation seems a little wide but I'm not really sure the right way to solve it. Seems for arrays/objects we'd need to treat em kinda special or something. Screenshot 2022-07-14 3 07 34 PM

TheWebTech commented 1 year ago

resolves #192