Gonzih / docker-csgo-server

Dockerfile for the CSGO server

MIT License

134 stars 54 forks source link

Question about run process in Dockerfile #3

Closed jammsen closed 7 years ago

jammsen commented 7 years ago

Hey guys, is there a reason why you dont use inline RUN commands more grouped? I counted 8 RUN commands with basic usage, which could be moved to one single RUN command. A benefit of this is, your Dockerfile doesnt create 8 AUFS layers on every machine its used. Example:

Setup all environments

ENV var1 ... ENV var2 ... ENV var3 ... ENV var4 ... RUN command1;command2;command3;

Greetings, jammsen

Gonzih commented 7 years ago

I did minor change in dockerfile, is that what you had in mind?

On 30/08/17 21:11, jammsen wrote:

Hey guys, is there a reason why dont use inline RUN commands more grouped? I counted 8 RUN commands with basic usage, which could be moved to one single RUN command. A benefit of this is, your Dockerfile doesnt create 8 AUFS layers on every machine its used. Example:

Setup alle Environments

ENV var1 ... ENV var2 ... ENV var3 ... ENV var4 ... RUN command1;command2;command3;

Greetings, jammsen

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Gonzih/docker-csgo-server/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQQI3VtfWYlgTZ9EZxMW1ap7q7SeJOPks5sdbPIgaJpZM4PH1-W.

jammsen commented 7 years ago

Wheeew yeah, 3 AUFS layers instead of 8, exactly what i meant, thanks!

Gonzih commented 7 years ago

Also you should not run aufs. Switch to overlay adapter.

On Aug 31, 2017 16:30, "jammsen" notifications@github.com wrote:

Wheeew yeah, 3 AUFS layers instead of 8, exactly what i meant, thanks!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Gonzih/docker-csgo-server/issues/3#issuecomment-326313588, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQQI1u8NhI7R-RVSoLL2rs5Ham5QQhbks5sdsORgaJpZM4PH1-W .

jammsen commented 7 years ago

Hey do you plan to publish this script as an image on hub.docker.com?

Gonzih commented 7 years ago

Image is too big for that (> 13GB i think), tried to push it. It takes hours and often due to networking issues abort is a thing that happens.

On 31/08/17 19:46, jammsen wrote:

Hey do you plan to publish this script as an image on hub.docker.com?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Gonzih/docker-csgo-server/issues/3#issuecomment-326371304, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQQIy4fyIy7ob8a3viweqzakb9jdnc1ks5sdvFlgaJpZM4PH1-W.

jammsen commented 7 years ago

Can you add me on twitter so we can talk more in detail? @jammsen