search

Gonzih / docker-csgo-server

Dockerfile for the CSGO server
MIT License
134 stars 54 forks source link

Volumes and env #7

Closed cgarnier closed 6 years ago

cgarnier commented 6 years ago

Hello, Could be nice to add some volumes to the dockerfile. /maps/custom /cfg/custom

and an environment configuration to be able to easily configure the server on startup (tickrate, hostname, rcon_password ...)

Gonzih commented 6 years ago

You can add volumes already via -v /hostpath:/containerpath, you dont need VOLUME declracation inside the container. Im not into parsing env vars and generating config based on that, just use your own config and command line argument. Simplicity.

On 20/10/17 11:50, Clément Garnier wrote:

Hello, Could be nice to add some volumes to the dockerfile. /maps/custom /cfg/custom

and an environment configuration to be able to easily configure the server on startup (tickrate, hostname, rcon_password ...)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Gonzih/docker-csgo-server/issues/7, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQQI9tVl1SWW9IV78seujj9uFrGukvMks5suGz7gaJpZM4QAb-1.

cgarnier commented 6 years ago

VOLUME is not an useless docker statement. It permit to docker to know what must be persisted. If you specify the module you can let docker deal with it. Else you have to use -v.

It s not in the docker spirit to have to setup something in the command or to have to manualy set the volumes.

Gonzih commented 6 years ago

PR is welcome.

On 20/10/17 13:47, Clément Garnier wrote:

VOLUME is not an useless docker statement. It permit to docker to know what must be persisted. If you specify the module you can let docker deal with it. Else you have to use -v.

It s not in the docker spirit to have to setup something in the command or to have to manualy set the volumes.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Gonzih/docker-csgo-server/issues/7#issuecomment-338184171, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQQIxXiiUlnJLAgEXZABeacfAEpQFU3ks5suIhggaJpZM4QAb-1.