search

Goobwabber / MultiplayerCore

A Beat Saber mod that implements core custom multiplayer functionality.
MIT License
66 stars 36 forks source link

Remove CustomSongColorsPatch (fixes #36) #37

Closed roydejong closed 1 year ago

roydejong commented 1 year ago

This PR removes the CustomSongColorsPatch with no other changes.

The patch itself is not working on the latest SongCore build, because of changes to their config (which causes issue #36 and effectively breaks multiplayer).

SongCore now handles custom song colors itself, so this patch is no longer needed here: https://github.com/Kylemc1413/SongCore/pull/48

rcelyte commented 1 year ago

Shouldn't the SongCore dependency version be updated to ensure the colors patch is present on that side?

roydejong commented 1 year ago

Shouldn't the SongCore dependency version be updated to ensure the colors patch is present on that side?

Good point, I've added that manifest change.

SongCore 3.10.1 is in the BeatMods approval queue for 1.28.0, so that version makes sense to target with a next MpCore release.