Goobwabber / MultiplayerCore

A Beat Saber mod that implements core custom multiplayer functionality.
MIT License
67 stars 36 forks source link

1.29 support (Graph API) #41

Closed roydejong closed 1 year ago

roydejong commented 1 year ago

This PR adds support for Beat Saber 1.29 by targeting GameLift API overrides rather than master server overrides, which are now no longer supported:

Cross-dependent related PRs

rcelyte commented 1 year ago

I was kind of hoping we could fuse the graph URL and status URL into one web host to simplify configuration 😕 (Official uses a single domain for both as well)

roydejong commented 1 year ago

I was kind of hoping we could fuse the graph URL and status URL into one web host to simplify configuration 😕 (Official uses a single domain for both as well)

I personally think that this adds a bit more flexibility in how server operators want to handle this.

In BT's case, for example, the status API and Graph API will most likely end up on completely different ports, so some granularity in defining that is desirable.

Nothing here is final though - this is just my proposal and is all open to discussion for sure

rcelyte commented 1 year ago

Appears to work perfectly on 1.29.0 :+1: (testing with UseCustomApiServer("https://master.battletrains.org", "https://master.battletrains.org");)

Kevman95 commented 1 year ago

Merging ;)